Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #104253: Pass additional flags to subpath mount to avoid flakes in #104347

Merged
merged 4 commits into from Aug 16, 2021
Merged

Automated cherry pick of #104253: Pass additional flags to subpath mount to avoid flakes in #104347

merged 4 commits into from Aug 16, 2021

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Aug 12, 2021 •
edited

Cherry pick of #104253 on release-1.21.

#104253: Pass additional flags to subpath mount to avoid flakes in

For details on the cherry pick process, see the cherry pick requests page.

Pass additional flags to subpath mount to avoid flakes in certain conditions

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 12, 2021
@mauriciopoppe
Copy link
Member Author

/uncc @gnufied @saad-ali
/cc @jsafrane @msau42 @jingxu97
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Aug 12, 2021
@mauriciopoppe
Copy link
Member Author

/sig storage

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 12, 2021
@mauriciopoppe
Copy link
Member Author

/retest

@jingxu97
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2021
@mauriciopoppe
Copy link
Member Author

hey @kubernetes/release-managers, could you please review this PR? thanks in advance!

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/triage accepted
/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2021
@cpanato cpanato removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2021
cpanato
cpanato approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from RelEng:
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jingxu97, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit f5a6d21 into kubernetes:release-1.21 Aug 16, 2021
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 9, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 17, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 26, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@cpanato cpanato

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mauriciopoppe @jingxu97 @cpanato @k8s-ci-robot