New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add CSIVolumeHealth feature and gate #99284
feature: add CSIVolumeHealth feature and gate #99284
Conversation
Hi @fengzixu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @xing-yang @NickrenREN @fengzixu |
/triage accepted |
/ok-to-test |
e862e69
to
bd8748c
Compare
/test pull-kubernetes-e2e-kind |
Thanks for your suggestion. I split this PR into 2 commits. Because add |
@sjenning You can check it now |
866f5d3
to
f87d229
Compare
pkg/volume/csi/csi_client_test.go
Outdated
@@ -74,38 +86,53 @@ func (c *fakeCsiDriverClient) NodeGetInfo(ctx context.Context) ( | |||
} | |||
|
|||
func (c *fakeCsiDriverClient) NodeGetVolumeStats(ctx context.Context, volID string, targetPath string) ( | |||
usageCountMap *volume.Metrics, err error) { | |||
usageCountMap *volume.Stats, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's still renaming in the first commit
f87d229
to
fdc348a
Compare
1. add EventRecorder to ResourceAnalyzer 2. add CSIVolumeHealth feature and gate
fdc348a
to
edc1c62
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fengzixu, msau42, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.21 |
/test pull-kubernetes-integration |
/test pull-kubernetes-integration |
@fengzixu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-integration |
Test failure is not related to this change. /lgtm |
@fengzixu Please rename the PR to: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
why we need it
According to the change of kep, we decide to move the responsibility (checking volume condition and reporting abnormal volume event to pod ) from external-health-monitor-agent to kubelet.
what this PR does
Which issue(s) this PR fixes:
Not yet.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: