Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 443 and 448 from cloud provider azure #97635

Merged
merged 2 commits into from Jan 20, 2021
Merged

Cherry pick 443 and 448 from cloud provider azure #97635

merged 2 commits into from Jan 20, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Dec 31, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:
Cherry pick 443 and 448 from cloud provider azure.
kubernetes-sigs/cloud-provider-azure#443: Use network.Interface.VirtualMachine.ID to get the binded VM.
kubernetes-sigs/cloud-provider-azure#448: Skip standalone VM when reconciling LoadBalancer.

Which issue(s) this PR fixes:

Fixes #97352
Fixes #97375

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Use network.Interface.VirtualMachine.ID to get the binded VM
Skip standalone VM when reconciling LoadBalancer

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cloud-provider
/area provider/azure
/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. area/cloudprovider labels Dec 31, 2020
@nilo19
Copy link
Member Author

nilo19 commented Dec 31, 2020

/retest

2 similar comments
@nilo19
Copy link
Member Author

nilo19 commented Dec 31, 2020

/retest

@nilo19
Copy link
Member Author

nilo19 commented Jan 1, 2021

/retest

feiskyer
feiskyer reviewed Jan 3, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes two serious bugs introduced since v1.20.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2021
@feiskyer
Copy link
Member

feiskyer commented Jan 4, 2021

/test pull-kubernetes-e2e-azure-disk-vmss

@sgreene570 sgreene570 mentioned this pull request Jan 4, 2021
Merged
@nilo19
Copy link
Member Author

nilo19 commented Jan 5, 2021

/retest

@feiskyer
Copy link
Member

feiskyer commented Jan 5, 2021

@andrewsykim could you help to approve this?

/assign @andrewsykim

@nilo19
Copy link
Member Author

nilo19 commented Jan 5, 2021

/retest

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented Jan 6, 2021

/retest

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-azure-disk-vmss

@andyzhangx
Copy link
Member 

Jan  6 04:52:00.235: INFO: At 2021-01-06 04:36:59 +0000 UTC - event for pvc-dhgpx: {persistentvolume-controller } ProvisioningFailed: Failed to provision volume with StorageClass "azuredisk-8081-kubernetes.io-azure-disk-dynamic-sc-bgn6g": AzureDisk -  failed to get Azure Cloud Provider. GetCloudProvider returned <nil> instead

@feiskyer
Copy link
Member

feiskyer commented Jan 6, 2021

the test failure is not related to this change. @andrewsykim could you help to approve this PR?

@andrewsykim
Copy link
Member

lgtm but can we split the commits so there's a commit per cherry-pick as well as a description in the commit for why this is a bug?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2021
@nilo19
Copy link
Member Author

nilo19 commented Jan 7, 2021

split the commit

@feiskyer
Copy link
Member

feiskyer commented Jan 7, 2021

/retest

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-azure-disk-vmss

andyzhangx
andyzhangx approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2021
@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-azure-disk-vmss

@nilo19
Copy link
Member Author

nilo19 commented Jan 13, 2021

kindly ping @andrewsykim any comments?

@feiskyer
Copy link
Member

ping @cheftako @andrewsykim could you help to approve the change?

andrewsykim
andrewsykim reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, andyzhangx, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nilo19
Copy link
Member Author

nilo19 commented Jan 20, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit ac0b037 into kubernetes:master Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-443-448 branch January 20, 2021 09:08
This was referenced Feb 6, 2021
Closed
Merged
@feiskyer feiskyer mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@andyzhangx andyzhangx

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Azure LB Availability Set assumptions too restrictive Azure LB NIC regex too restrictive
6 participants
@nilo19 @feiskyer @andyzhangx @andrewsykim @k8s-ci-robot @fejta-bot