Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower the frequency of volume plugin deprecation warning #96751

Merged
merged 1 commit into from Dec 9, 2020
Merged

Lower the frequency of volume plugin deprecation warning #96751

merged 1 commit into from Dec 9, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Nov 20, 2020 •
edited by liggitt

What type of PR is this?
/kind bug

What this PR does / why we need it:
The warning is always logged (klog.Warningf), so make sure it's logged only once per process. We've seen clusters where the deprecation warning was about 20% of total logs.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jsafrane
Lower the frequency of volume plugin deprecation warning
62ecc68 
The warning is always logged (klog.Warningf), so make sure it's logged only
once per process. We've seen clusters where the deprecation warning was
about 20% of total logs.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

@jsafrane: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 20, 2020
@jsafrane
Copy link
Member Author

@kubernetes/provider-openstack-pr-reviews, FYI.

Fedosin
Fedosin approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor

Fedosin commented Nov 23, 2020

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit d543031 into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@jsafrane jsafrane mentioned this pull request Dec 15, 2020
Merged
This was referenced Jan 10, 2021
Merged
Merged
Merged
@ialidzhikov
Copy link
Contributor

ialidzhikov commented Jan 10, 2021 •
edited

We also hit this issue as we have this warning message repeated 228523 times in all 245594 lines of logs. See:

$ cat kube-controller-manager-fc56c548f-87gpf.log | wc -l
245594

$ cat kube-controller-manager-fc56c548f-87gpf.log | grep 'kubernetes.io/cinder built-in volume provider is now deprecated' | wc -l
228523

This is the reason why I also proposed the following cherry-picks:

k8s-ci-robot added a commit that referenced this pull request Feb 2, 2021
@k8s-ci-robot
Merge pull request #97893 from ialidzhikov/automated-cherry-pick-of-#…
3993be4 
…96751-upstream-release-1.19

Automated cherry pick of #96751: Lower the frequency of volume plugin deprecation warning
k8s-ci-robot added a commit that referenced this pull request Feb 2, 2021
@k8s-ci-robot
Merge pull request #97892 from ialidzhikov/automated-cherry-pick-of-#…
5eac3d1 
…96751-upstream-release-1.20

Automated cherry pick of #96751: Lower the frequency of volume plugin deprecation warning
k8s-ci-robot added a commit that referenced this pull request Feb 2, 2021
@k8s-ci-robot
Merge pull request #97894 from ialidzhikov/automated-cherry-pick-of-#…
9f76669 
…96751-upstream-release-1.18

Automated cherry pick of #96751: Lower the frequency of volume plugin deprecation warning
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 1, 2021
Merged
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin approved these changes

@humblec humblec Awaiting requested review from humblec

@msau42 msau42 Awaiting requested review from msau42

Assignees

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @k8s-ci-robot @Fedosin @ialidzhikov