Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip visiting empty secret and configmap names #99538

Merged
merged 1 commit into from Mar 1, 2021
Merged

Skip visiting empty secret and configmap names #99538

merged 1 commit into from Mar 1, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 27, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes #99454

Does this PR introduce a user-facing change?

Resolves spurious `Failed to list *v1.Secret` or `Failed to list *v1.ConfigMap` messages in kubelet logs.

/sig node auth

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2021
@liggitt liggitt mentioned this pull request Feb 27, 2021
Closed
@liggitt
Copy link
Member Author

liggitt commented Feb 27, 2021

/cc @wojtek-t
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Feb 27, 2021

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2021
@liggitt
Copy link
Member Author

liggitt commented Feb 28, 2021

#99505 flake

/retest

@wojtek-t
Copy link
Member

wojtek-t commented Mar 1, 2021

/lgtm

Thanks for fixing Jordan!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 793390e into kubernetes:master Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
@liggitt liggitt deleted the skip-empty-names branch March 1, 2021 13:11
This was referenced Mar 1, 2021
Merged
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2021

Opened picks to release branches.

k8s-ci-robot added a commit that referenced this pull request Mar 6, 2021
@k8s-ci-robot
Merge pull request #99587 from liggitt/automated-cherry-pick-of-#9953…
c4af468 
…8-upstream-release-1.20

Automated cherry pick of #99538: Skip visiting empty secret and configmap names
k8s-ci-robot added a commit that referenced this pull request Mar 6, 2021
@k8s-ci-robot
Merge pull request #99588 from liggitt/automated-cherry-pick-of-#9953…
02b9dd6 
…8-upstream-release-1.19

Automated cherry pick of #99538: Skip visiting empty secret and configmap names
k8s-ci-robot added a commit that referenced this pull request Mar 7, 2021
@k8s-ci-robot
Merge pull request #99589 from liggitt/automated-cherry-pick-of-#9953…
298c412 
…8-upstream-release-1.18

Automated cherry pick of #99538: Skip visiting empty secret and configmap names
@liggitt liggitt mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Kubelet fails to retrieve secret with empty name
3 participants
@liggitt @k8s-ci-robot @wojtek-t