Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cinder volume detection on OpenStack Train #96673

Merged
merged 1 commit into from Dec 9, 2020
Merged

Fix Cinder volume detection on OpenStack Train #96673

merged 1 commit into from Dec 9, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Nov 18, 2020 •
edited

/kind bug

What this PR does / why we need it:
Newer OpenStack does not truncate volumeID to 20 characters.

/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_033fa19a-a5e3-445a-8631-3e9349e540e5 was seen on OpenStack 16 node.

Fixes: #96672

Does this PR introduce a user-facing change?:

Fixed Cinder volume IDs on OpenStack Train

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 18, 2020
@jsafrane
Copy link
Member Author

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2020
@jsafrane jsafrane changed the title Fix Cinder volume detection on OpenStack 16 Fix Cinder volume detection on OpenStack Train Nov 18, 2020
zetaab
zetaab approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

but like mentioned in Slack, in-tree OpenStack cloudprovider is deprecated and will be removed soon from k/k (was it 1.22?). So I would start migrating to external cloudproviders like now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
mdbooth
mdbooth reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, but there are some problems in the commit message:

OpenStack 16 was OpenStack Pike, which Red Hat released as OSP 12. I'm guessing you meant OSP 16, which is OpenStack Train.

However, OpenStack has never truncated the volume id anyway. I don't recall the details now, but it's truncated either by the hypervisor or the guest kernel, I think the latter, and is dependent on the driver used. I remember it's ill-defined and the behaviour can differ even on the same software version depending on use.

OSP (as opposed to OpenStack) 16 defines the whole stack including the hypervisor and kernel, so is likely more relevant here. OpenStack Train (which is upstream version 20) would differ anyway depending on which platform it's running on.

Yeah, it's not confusing at all :) The downstream nova team keeps a magic decoder ring for exactly this reason.

If the contents of the commit message might ever be important to anybody you should probably fix it.

@jsafrane
Fix Cinder volume detection on OpenStack Train
92c3895 
Newer OpenStack does not truncate volumeID to 20 characters.
/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_033fa19a-a5e3-445a-8631-3e9349e540e5
was seen on an OpenStack Train node.
@jsafrane
Copy link
Member Author

Updated to OpenStack Train.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Nov 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
Fedosin
Fedosin approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same changes were done for the CSI driver: kubernetes/cloud-provider-openstack#853

@jsafrane
Copy link
Member Author

/assign @dims @NickrenREN
for approval

@NickrenREN
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, jsafrane, NickrenREN, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
This was referenced Dec 1, 2020
Closed
Closed
Closed
@k8s-ci-robot k8s-ci-robot merged commit 31fd567 into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 9, 2020
@jsafrane jsafrane mentioned this pull request Dec 15, 2020
Merged
@remche remche mentioned this pull request Dec 18, 2020
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth left review comments

@Fedosin Fedosin Fedosin approved these changes

@zetaab zetaab zetaab approved these changes

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@dims dims

@NickrenREN NickrenREN

@Fedosin Fedosin

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Cinder volume attachment detection failure in Kubelet
7 participants
@jsafrane @Fedosin @NickrenREN @k8s-ci-robot @mdbooth @zetaab @dims