Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Immutable Secrets/ConfigMaps to Stable #97615

Merged
merged 3 commits into from Jan 7, 2021
Merged

Promote Immutable Secrets/ConfigMaps to Stable #97615

merged 3 commits into from Jan 7, 2021

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Dec 30, 2020 •
edited by liggitt

Ref kubernetes/enhancements#1412

Promote Immutable Secrets/ConfigMaps feature to Stable. This allows to set `immutable` field in Secret or ConfigMap object to mark their contents as immutable.

/kind feature
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 30, 2020
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 30, 2020
@wojtek-t
Copy link
Member Author

/hold

Pending KEP approval: kubernetes/enhancements#2179

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2020
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Dec 30, 2020
@msau42
Copy link
Member

msau42 commented Jan 5, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@saad-ali
Copy link
Member

saad-ali commented Jan 5, 2021

/lgtm
/approve

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 5, 2021

Cancelling hold - KEP has been approved.

Will ask for api and conformance approval.

@wojtek-t wojtek-t added this to the v1.21 milestone Jan 5, 2021
thockin
thockin reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 6, 2021

Thanks Tim!

/assign @johnbelamaric

John - can you please review the conformance part?

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Jan 6, 2021
@ehashman ehashman removed this from Needs Approver in SIG Node PR Triage Jan 6, 2021
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, msau42, saad-ali, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@wojtek-t
Copy link
Member Author

wojtek-t commented Jan 7, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit c5cc25d into kubernetes:master Jan 7, 2021
@wojtek-t wojtek-t mentioned this pull request Jan 25, 2021
Closed
@irvifa irvifa mentioned this pull request Feb 12, 2021
Merged
@mengjiao-liu mengjiao-liu mentioned this pull request Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees

@thockin thockin

@johnbelamaric johnbelamaric

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wojtek-t @k8s-ci-robot @msau42 @saad-ali @johnbelamaric @fejta-bot @thockin