Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Welcome @abelbarrera15!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @abelbarrera15. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test
/assign @ereslibre @neolit123

ammended the original email that was used in the git commit (accidentally was not the one in the CLA) then resett back to a single git commit to remove do-not-merge/contains-merge-commits. CLA email now matches as well as my username. CLA should match exactly BOTH my username and my email address. If still NO-CLA by tomorrow I will report to the CLA people this issue.

something else - please change:

Fixes (kubernetes/kubeadm#2365)

to

Fixes kubernetes/kubeadm#2365

which will trigger the close on the original issue.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abelbarrera15, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

please squash the commits to one. i can re-apply LGTM after that.

please squash the commits to one. i can re-apply LGTM after that.

@neolit123 , it's been squashed to one commit now

/lgtm

useful commands are:

# interactive rebase, it opens a text editor where you can mark the second commit as "f"
# "f" stands for fixup which will merge the code of the second commit into the first one and remove the second commit
git rebase -i HEAD~2
# you can then force push the single commit to your remove branch
git push -f ...

more info on rebase:
https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

/lgtm

useful commands are:

# interactive rebase, it opens a text editor where you can mark the second commit as "f"
# "f" stands for fixup which will merge the code of the second commit into the first one and remove the second commit
git rebase -i HEAD~2
# you can then force push the single commit to your remove branch
git push -f ...

more info on rebase:
https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

Thank you! I appreciate this. I had the rebase going, but I kept messing up the way to push such that it didn't make a new commit with the squash of the two commits.