Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] [go] Update Go to 1.17.7 #108100

Merged
merged 1 commit into from Feb 14, 2022
Merged

[release-1.23] [go] Update Go to 1.17.7 #108100

merged 1 commit into from Feb 14, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Feb 14, 2022 •
edited

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update Go to 1.17.7.

Which issue(s) this PR fixes:

xref kubernetes/release#2425

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @cpanato @saschagrunert @palnabarun @puerco @justaugustus
cc @kubernetes/release-engineering

@xmudrii
Update Go to 1.17.7
c465cec 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider labels Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/triage accepted
/priority improtant-soon

@k8s-ci-robot
Copy link
Contributor

@xmudrii: The label(s) priority/improtant-soon cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/priority improtant-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 14, 2022
justaugustus
justaugustus approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2022
@justaugustus
Copy link
Member

/assign @dims @liggitt

@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/retest

cpanato
cpanato approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xmudrii
Copy link
Member Author

xmudrii commented Feb 14, 2022

/retest

This was referenced Feb 14, 2022
Merged
Closed
Merged
Merged
@dims
Copy link
Member

dims commented Feb 14, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2022
@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1ba2054 into kubernetes:release-1.23 Feb 14, 2022
@xmudrii xmudrii deleted the 1.23-go117 branch February 14, 2022 14:11
@cpanato cpanato mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@cpanato cpanato cpanato approved these changes

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@dims dims

@justaugustus justaugustus

@saschagrunert saschagrunert

@liggitt liggitt

@puerco puerco

@cpanato cpanato

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@xmudrii @k8s-ci-robot @justaugustus @dims @cpanato @saschagrunert @liggitt @puerco @palnabarun