Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #482 from cloud provider azure: aggregate errors when putting vmss #98350

Merged
merged 1 commit into from May 21, 2021
Merged

Cherry pick #482 from cloud provider azure: aggregate errors when putting vmss #98350

merged 1 commit into from May 21, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jan 25, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:
https://github.com/kubernetes-sigs/cloud-provider-azure/pull/482/commits: Aggregate errors when putting vmss, so the failure of the previous update would not interrupt the next ones.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#481

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

aggregate errors when putting vmss

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority critical-urgent
/triage accepted
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider area/cloudprovider labels Jan 25, 2021
This was referenced Jan 25, 2021
Merged
Merged
Merged
feiskyer
feiskyer reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
@nilo19
Copy link
Member Author

nilo19 commented Jan 26, 2021

/retest

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented Jan 26, 2021

/retest

@feiskyer
Copy link
Member

@andrewsykim could you help to approve this cherry pick?

/assign andrewsykim

k8s-ci-robot added a commit that referenced this pull request Feb 4, 2021
@k8s-ci-robot
Merge pull request #98351 from nilo19/automated-cherry-pick-of-#98350…
f89e356 
…-upstream-release-1.20

Automated cherry pick of #98350: aggregate errors when putting vmss
k8s-ci-robot added a commit that referenced this pull request Feb 4, 2021
@k8s-ci-robot
Merge pull request #98353 from nilo19/bug/cherry-pick-482-1.18
ff6c1e8 
Automated cherry pick of #98350: aggregate errors when putting vmss
k8s-ci-robot added a commit that referenced this pull request Feb 4, 2021
@k8s-ci-robot
Merge pull request #98352 from nilo19/automated-cherry-pick-of-#98350…
698cfe4 
…-upstream-release-1.19

Automated cherry pick of #98350: aggregate errors when putting vmss
@feiskyer
Copy link
Member

feiskyer commented Apr 1, 2021

/test pull-kubernetes-unit

ping @andrewsykim @cheftako for approval

@nilo19
Copy link
Member Author

nilo19 commented May 11, 2021

ping @andrewsykim @cheftako for approval

@cheftako
Copy link
Member

A little confusing labelling this as a cherry pick. I realize your forklifting a fix from cloud provider azure, but generally when we refer to cherry picks we are referring to backporting fixes within K/K to an older branch, rather than importing fixes from another repo.

cheftako
cheftako reviewed May 11, 2021
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure_vmss.go
for vmssName := range vmssNamesMap {
vmssName := vmssName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a comment explaining why you are shadowing this variable.

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 21, 2021
feiskyer
feiskyer reviewed May 21, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@nilo19
Copy link
Member Author

nilo19 commented May 21, 2021

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fadf85d into kubernetes:master May 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 21, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-482 branch May 24, 2021 13:24
k8s-ci-robot added a commit that referenced this pull request Oct 13, 2021
@k8s-ci-robot
Merge pull request #105365 from nilo19/automated-cherry-pick-of-#1051…
22e60b5 
…88-upstream-release-1.21

Cherry pick of #105188 and #98350 to release 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@cheftako cheftako cheftako left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

@cheftako cheftako

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Not all node pools are cleaned up on ILB deletion
6 participants
@nilo19 @feiskyer @cheftako @k8s-ci-robot @fejta-bot @andrewsykim