Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubelet from panic after getting the wrong signal #98200

Merged
merged 1 commit into from Jan 20, 2021
Merged

Fix kubelet from panic after getting the wrong signal #98200

merged 1 commit into from Jan 20, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jan 20, 2021 •
edited by liggitt

What type of PR is this?
/kind bug
/sig node

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #97951

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubelet: Fix kubelet from panic after getting the wrong signal

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wzshiming. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet labels Jan 20, 2021
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2021
@bobbypage
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2021
@bobbypage bobbypage mentioned this pull request Jan 20, 2021
Closed
@bobbypage
Copy link
Member

bobbypage commented Jan 20, 2021 •
edited

@wzshiming thanks for re-opening this, sorry for the confusion on #97952.

I agree this is still an issue and needs to be fixed.

Can you please make it clear in the PR description this fixes two issues:

  1. If the PrepareForShutdown event is nil or len(event.Body) == 0 it should not fall through and
    continue to read the body
  2. If the PrepareForShutdown is malformed (i.e. nil, len(event.Body) == 0, or it's not a bool), the loop should continue and skip over the event rather and break.

@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@bobbypage
Copy link
Member

/assign @mrunalp

@bobbypage
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2021
@wzshiming
Copy link
Member Author

/retest

@mrunalp
Copy link
Contributor

mrunalp commented Jan 20, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 737858c into kubernetes:master Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 20, 2021
@wzshiming wzshiming deleted the fix-node-shutdown-events branch January 23, 2021 06:24
@wzshiming wzshiming mentioned this pull request Jan 25, 2021
Closed
6 tasks
@github-actions github-actions bot mentioned this pull request Jan 26, 2021
Open
@ialidzhikov
Copy link
Contributor

@wzshiming , does it make sense to cherry-pick this PR into release-1.20?

@wzshiming wzshiming mentioned this pull request Feb 15, 2021
Merged
@wzshiming
Copy link
Member Author

I think it still makes sense. #99091

k8s-ci-robot added a commit that referenced this pull request Mar 12, 2021
@k8s-ci-robot
Merge pull request #99091 from wzshiming/automated-cherry-pick-of-#98…
6776ccf 
…200-upstream-release-1.20

Automated cherry pick of #98200: Fix dbus shutdown events not continuing if they are not valid
@bobbypage bobbypage mentioned this pull request Mar 18, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge Awaiting requested review from odinuge

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

GracefulNodeShutdown dbus shutdown events not continuing if they are not valid
6 participants
@wzshiming @k8s-ci-robot @fejta-bot @bobbypage @mrunalp @ialidzhikov