Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VolumeSubpath feature gate #105090

Merged
merged 1 commit into from Sep 17, 2021
Merged

Remove VolumeSubpath feature gate #105090

merged 1 commit into from Sep 17, 2021

Conversation

saad-ali
Copy link
Member

@saad-ali saad-ali commented Sep 17, 2021 •
edited

What type of PR is this?

/kind cleanup

/kind deprecation

What this PR does / why we need it:

Remove the VolumeSubpath feature gate.

Per @liggitt:

Feature gate convention has been updated since this feature gate was introduced to indicate that they are intended to be deprecated and removed after a feature becomes GA or is dropped.

Also, turning off the gate would make a cluster non-conformant and couldn't reasonably be done by a managed cluster provider without breaking existing users.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

@saad-ali: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 17, 2021 •
edited

/lgtm

Question 1: In my impression, there are several subpath-related issues and I did a quick search. Do we have a plan to think about the solution together? I will go through them once I have some reproducing environments.

_Question 2:
“VolumeSubpath was GAed since 1.10. Besides, VolumeSubpathEnvExpansion was also GAed since 1.17 (6 releases after that).”
Is there a plan to remove it? (EDITED: sorry, I find the website is not synced with the code. This feature gate is already removed in #89584)_

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@saad-ali
Copy link
Member Author

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 17, 2021
@saad-ali saad-ali added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 17, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 17, 2021
@saad-ali
Copy link
Member Author

Question 1: In my impression, there are several subpath-related issues and I did a quick search. Do we have a plan to think about the solution together? I will go through them once I have some reproducing environments.

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

@saad-ali
Remove VolumeSubpath feature gate
beb17fe 
Remove the VolumeSubpath feature gate.

Feature gate convention has been updated since this was introduced to
indicate that they "are intended to be deprecated and removed after a
feature becomes GA or is dropped.".
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 17, 2021 •
edited

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

I need to do some basic code reading and summary before raising it in the meeting. (If the meeting time is not convenient for me, I may raise the discussion in slack.) Thanks.

@saad-ali
Copy link
Member Author

Good topic for discussion with SIG Storage. Want to add it to the agenda for the next meeting?

I need to do some basic code reading and summary before raising it in the meeting. (If the meeting time is not convenient for me, I may raise the discussion in slack.) Thanks.

Sounds good!

@thockin
Copy link
Member

thockin commented Sep 17, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@thockin
Copy link
Member

thockin commented Sep 17, 2021

There are issues with subpath, especially wrt projected volumes. I'd love to see us tackle that.

@k8s-ci-robot k8s-ci-robot merged commit 0d20f47 into kubernetes:master Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 17, 2021
@msau42
Copy link
Member

msau42 commented Sep 30, 2021

I think we actually need to lock to default, and the deprecate for 2 releases before removing. Will send an update.

@mauriciopoppe mauriciopoppe mentioned this pull request Oct 4, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

@saad-ali: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 4, 2021
@saad-ali
Copy link
Member Author

saad-ali commented Oct 4, 2021

#105474 is handling the release note for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@pacoxu pacoxu

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saad-ali @k8s-ci-robot @pacoxu @thockin @msau42