Add btrfs support to the automatic volume resizer #99361

Novex · 2021-02-23T16:03:18Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds support for automatically resizing a btrfs volume when the underlying PV is increased. Without this, if a PV is increased that uses the btrfs format it will fail to mount after pod restart (causing the pod to be stuck in the Init state) with the following error until it the PV and PVC are recreated:

  Warning  FailedMount  14s (x12 over 8m39s)  kubelet            MountVolume.MountDevice failed while expanding volume for volume "libero-data-btrfs-alpha-2-dev" : ResizeFS.Resize - resize of format btrfs is not supported for device /dev/nvme1n1 mounted at /var/lib/kubelet/plugins/kubernetes.io/aws-ebs/mounts/vol-01c...282

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

I tested this in our v1.19.7 development cluster, but it should work fine in later versions too.

Does this PR introduce a user-facing change?

Persistent Volumes formatted with the btrfs filesystem will now automatically resize when expanded.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2021-02-23T16:03:21Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-02-23T16:03:26Z

Welcome @Novex!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-02-23T16:03:27Z

Hi @Novex. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Novex · 2021-02-23T16:09:33Z

CLA signed

Novex · 2021-02-23T16:11:03Z

/sig storage

gnufied · 2021-02-23T16:18:35Z

/ok-to-test

gavinfish · 2021-02-23T16:57:58Z

staging/src/k8s.io/mount-utils/resizefs_linux.go

+
+func (resizefs *ResizeFs) btrfsResize(deviceMountPath string) (bool, error) {
+	args := []string{"filesystem", "resize", "max", deviceMountPath}
+	output, err := resizefs.mounter.Exec.Command("btrfs", args...).CombinedOutput()


Suggested change

output, err := resizefs.mounter.Exec.Command("btrfs", args...).CombinedOutput()

output, err := resizefs.exec.Command("btrfs", args...).CombinedOutput()

we have changed from mounter to exec here.

thanks for the direction, I didn't realise more than just the file paths got refactored earlier today

Novex · 2021-02-23T17:54:09Z

/retest

gnufied · 2021-02-24T03:11:53Z

/lgtm

gnufied · 2021-02-24T03:12:12Z

/triage accepted
/priority important-soon

gnufied · 2021-02-24T03:14:13Z

/assign @jingxu97

jingxu97 · 2021-03-01T21:50:36Z

/approve
/lgtm

k8s-ci-robot · 2021-03-01T21:50:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, Novex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/mount-utils/OWNERS~~ [jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pacoxu · 2021-03-02T05:40:17Z

/test pull-kubernetes-unit
the bot seems to hang.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2021

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 23, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2021

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 23, 2021

k8s-ci-robot requested review from jsafrane and msau42 February 23, 2021 16:04

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 23, 2021

k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 23, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021

gavinfish reviewed Feb 23, 2021

View reviewed changes

Add btrfs support to the automatic volume resizer

1bb8960

Novex force-pushed the btrfs-volume-resize branch from 94b1958 to 1bb8960 Compare February 23, 2021 17:01

k8s-ci-robot assigned gnufied Feb 24, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2021

k8s-ci-robot assigned jingxu97 Feb 24, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021

k8s-ci-robot merged commit 930bede into kubernetes:master Mar 2, 2021

k8s-ci-robot added this to the v1.21 milestone Mar 2, 2021

Novex deleted the btrfs-volume-resize branch March 2, 2021 10:39

fnkr mentioned this pull request Mar 16, 2021

Add BTRFS support hetznercloud/csi-driver#186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add btrfs support to the automatic volume resizer #99361

Add btrfs support to the automatic volume resizer #99361

Novex commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

Novex commented Feb 23, 2021

Novex commented Feb 23, 2021

gnufied commented Feb 23, 2021

gavinfish Feb 23, 2021

Novex Feb 23, 2021

Novex commented Feb 23, 2021

gnufied commented Feb 24, 2021

gnufied commented Feb 24, 2021

gnufied commented Feb 24, 2021

jingxu97 commented Mar 1, 2021

k8s-ci-robot commented Mar 1, 2021

pacoxu commented Mar 2, 2021

	output, err := resizefs.mounter.Exec.Command("btrfs", args...).CombinedOutput()
	output, err := resizefs.exec.Command("btrfs", args...).CombinedOutput()

Add btrfs support to the automatic volume resizer #99361

Add btrfs support to the automatic volume resizer #99361

Conversation

Novex commented Feb 23, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

k8s-ci-robot commented Feb 23, 2021

Novex commented Feb 23, 2021

Novex commented Feb 23, 2021

gnufied commented Feb 23, 2021

gavinfish Feb 23, 2021

Choose a reason for hiding this comment

Novex Feb 23, 2021

Choose a reason for hiding this comment

Novex commented Feb 23, 2021

gnufied commented Feb 24, 2021

gnufied commented Feb 24, 2021

gnufied commented Feb 24, 2021

jingxu97 commented Mar 1, 2021

k8s-ci-robot commented Mar 1, 2021

pacoxu commented Mar 2, 2021