Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote DownwardAPIHugePages to beta #99610

Merged
merged 1 commit into from Mar 2, 2021
Merged

Promote DownwardAPIHugePages to beta #99610

merged 1 commit into from Mar 2, 2021

Conversation

derekwaynecarr
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

The PR promotes DownwardAPIHugePages to beta.
The feature is safe to use on new installs, but is not on by default until 1.22 when all kubelets with n-2 skew have the capability.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Related KEP:
kubernetes/enhancements#2352

Does this PR introduce a user-facing change?

The DownwardAPIHugePages feature is beta.  Users may use the feature if all workers in their cluster are min 1.20 version.  The feature will be enabled by default in all installations in 1.22.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2053-downward-api-hugepages

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 1, 2021

/triage accepted
/priority important-soon
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 1, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@derekwaynecarr
Copy link
Member Author

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
@troy0820 troy0820 removed their assignment Mar 2, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 2, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 2, 2021
@troy0820 troy0820 added this to Needs Reviewer in SIG Node PR Triage Mar 2, 2021
@troy0820
Copy link
Member

troy0820 commented Mar 2, 2021

/assign @dims

@mrunalp
Copy link
Contributor

mrunalp commented Mar 2, 2021

/approve

@mrunalp mrunalp moved this from Needs Reviewer to Done in SIG Node PR Triage Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3022b39 into kubernetes:master Mar 2, 2021
@annajung annajung mentioned this pull request Mar 4, 2021
Closed
6 tasks
@troy0820 troy0820 mentioned this pull request Mar 15, 2021
Closed
13 tasks
@wangyysde wangyysde mentioned this pull request May 19, 2021
Closed
@mysunshine92 mysunshine92 mentioned this pull request Nov 9, 2021
Merged
@troy0820 troy0820 mentioned this pull request Dec 20, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@derekwaynecarr @troy0820 @mrunalp @k8s-ci-robot @dims