Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker remote / docker-machine from build scripts #97618

Merged
merged 1 commit into from Jan 6, 2021
Merged

Remove docker remote / docker-machine from build scripts #97618

merged 1 commit into from Jan 6, 2021

Conversation

jesusha123
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove docker-machine / remote docker support from build scripts.

Docker-machine is no longer accepting new features and in maintenance mode only. Team agreed to remove docker-machine / docker remote support in slack chat to simplify build scripts: https://kubernetes.slack.com/archives/C2C40FMNF/p1598059799085900

Which issue(s) this PR fixes:
Part of #94091.

A new contributor expressed interest in updating the doc only, so I skipped that part. Only build/README.md needs to be udpated.

Special notes for your reviewer:
I ran a regex search on the code base: "docker.machine|docker.remote|remote.docker", and inspected the build scripts to determine what needed to be removed.

I ran the following tests to make sure build scripts were not broken:

  • Run build/run.sh make on Ubuntu 20.04. Completes successfully.
  • Run build/run.sh make on MacOS Catalina. Completes successfully.
  • Run build/run.sh make on MacOS Catalina without docker daemon, only docker client installed. Fails as expected and displays the following messages:
+++ [1230 13:18:03] Verifying Prerequisites....
+++ [1230 13:18:03] No docker host is set.
+++ [1230 13:18:03] It looks like you're running Mac OS X, but Docker for Mac cannot be found.
+++ [1230 13:18:03] See: https://docs.docker.com/engine/installation/mac/ for installation instructions.

Does this PR introduce a user-facing change?:

-->

Official support to build kubernetes with docker-machine / remote docker is removed. This change does not affect building kubernetes with docker locally.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 30, 2020
@k8s-ci-robot
Copy link
Contributor

@jherrera123: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 30, 2020
@jesusha123
Copy link
Contributor Author

/sig testing
/sig release

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 30, 2020
@jesusha123
Copy link
Contributor Author

/cc @BenTheElder

@jesusha123
Copy link
Contributor Author

/retest

@adeniyistephen
Copy link
Contributor

Nice one

fejta
fejta reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, jherrera123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@jesusha123
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9c894e2 into kubernetes:master Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 6, 2021
@dims
Copy link
Member

dims commented Jan 7, 2021

about time :)

@github-actions github-actions bot mentioned this pull request Jan 12, 2021
Open
@spiffxp spiffxp mentioned this pull request Jan 15, 2021
Merged
@puerco puerco mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jesusha123 @k8s-ci-robot @adeniyistephen @dims @fejta