New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kustomize-in-kubectl to v4.0.5 #98946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/bug
Categorizes issue or PR as related to a bug.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
Issues or PRs related to dependency changes
area/kubectl
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
sig/instrumentation
Categorizes an issue or PR as relevant to SIG Instrumentation.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
and removed
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Feb 10, 2021
monopole
changed the title
Upgrade kustomize
Upgrade kustomize-in-kubectl to use kustomize/api@v0.8.0
Feb 10, 2021
BenTheElder
reviewed
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- these files should not be checked in and are left behind by buggy unit tests: unit tests leaving behind xtables.lock #98947
- pkg/util/iptables/xtables-103516112.lock
- pkg/util/iptables/xtables-103657263.lock
- pkg/util/iptables/xtables-104036897.lock
- This is a pretty huge diff 😬
- Some of the dependencies appear to be under licenses that are not approved by the CNCF
Does this totally resolve the k8sdeps thing?
monopole
changed the title
Upgrade kustomize-in-kubectl to use kustomize/api@v0.8.0
Upgrade kustomize-in-kubectl to kustomize@v3.10.0
Feb 10, 2021
monopole
force-pushed
the
upgradeKustomize
branch
from
February 10, 2021 14:46
19a9bd2
to
afcbc5c
Compare
/remove-sig instrumentation |
monopole
force-pushed
the
upgradeKustomize
branch
from
March 9, 2021 00:51
34bd6d5
to
ba39d22
Compare
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 9, 2021
@dims, thanks. Just pushed a fresh rebase. |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 9, 2021
/test pull-kubernetes-integration |
liggitt
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Mar 9, 2021
/skip |
/triage accepted |
k8s-ci-robot
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Mar 9, 2021
cedarkuo
added a commit
to cedarkuo/kustomize
that referenced
this pull request
Sep 27, 2021
…ple. Kubernetes v1.21 upgrade kustomize-in-kubectl to v4.0.5. kubernetes/kubernetes#98946 So I think this example could update back to use resources instead of bases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
area/cloudprovider
area/code-generation
area/conformance
Issues or PRs related to kubernetes conformance tests
area/dependency
Issues or PRs related to dependency changes
area/kubectl
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/architecture
Categorizes an issue or PR as relevant to SIG Architecture.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
sig/instrumentation
Categorizes an issue or PR as relevant to SIG Instrumentation.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/storage
Categorizes an issue or PR as relevant to SIG Storage.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/sig cli
/priority important-soon
What this PR does / why we need it:
Fixes kubernetes-sigs/kustomize#1500
Fixes kubernetes/kubectl#818
Special notes for your reviewer:
This PR has these commits:
Only the second commit has manual code edits. The change in
kustomizevisitor_test.go
is due to a bug fix (kubernetes-sigs/kustomize#1899).Deletion of the old code results in many dependency upgrades, and associated vendor updates.
Does this PR introduce a user-facing change?: