New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick #465 in cloud provider azure: Cleanup subnet in frontend IP configs #98133
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @cheftako @andrewsykim |
/assign @liggitt |
redirecting, I'm only in the approvers list for dep updates /unassign |
@@ -183,11 +183,40 @@ func (az *Cloud) CreateOrUpdateSecurityGroup(sg network.SecurityGroup) error { | |||
return rerr.Error() | |||
} | |||
|
|||
func cleanupSubnetInFrontendIPConfigurations(lb *network.LoadBalancer) network.LoadBalancer { | |||
if lb.LoadBalancerPropertiesFormat == nil || lb.FrontendIPConfigurations == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for checking if LoadBalancerPropertiesFormat
is nil? I don't see it used below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lb.FrontendIPConfigurations
is actually lb.LoadBalancerPropertiesFormat.FrontendIPConfigurations
ping @andrewsykim. Could you help to approve this change? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Cleanup subnet in frontend IP configs to prevent huge subnet request bodies in some scenarios.
Ref: kubernetes-sigs/cloud-provider-azure#465
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority critical-urgent
/area provider/azure
/sig cloud-provider
/triage accepted