Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #90980: Avoid using socket for hints #99276

Merged
merged 2 commits into from Mar 11, 2021
Merged

Automated cherry pick of #90980: Avoid using socket for hints #99276

merged 2 commits into from Mar 11, 2021

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented Feb 20, 2021 •
edited

Cherry pick of #90980 on release-1.19.

#90980: Avoid using socket for hints

For details on the cherry pick process, see the cherry pick requests page.

Using NUMA nodes instead of sockets for CPU manager hints.

@AlexeyPerevalov @iwankgb
Avoid using socket for hints
54a2d77 
Sockets don't affect performance as NUMA node does, since NUMA
node has dedicated memory controller, but socket it's physical
extension point.
Socket it's only cpu specific thing and it's strange to merge bitmask of
deviceplugin's and cpu manager, when cpu manager takes into account
socket.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
@AlexeyPerevalov @iwankgb
move to cadvisor.MachineInfo
33547e4 
This patch removes GetNUMANodeInfo, cadvisor.MachineInfo will be used
instead of it. GetNUMANodeInfo was introduced due to difference of meaning of
MachineInfo.Topology. On the arm it was NUMA nodes, but on the x86 it
represents sockets (since reading from /proc/cpuinfo). Now it unified
and MachineInfo.Topology represents NUMA node.

Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 20, 2021
@iwankgb iwankgb force-pushed the automated-cherry-pick-of-#90980-upstream-release-1.19 branch from 7a37787 to 33547e4 Compare February 20, 2021 20:18
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @iwankgb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 20, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 20, 2021

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 20, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 20, 2021

This cherry-pick accompanies #99209 to fix #98870 for 1.19.

@ehashman ehashman added this to Triage in SIG Node PR Triage Feb 22, 2021
@ehashman
Copy link
Member

ehashman commented Feb 23, 2021 •
edited

@iwankgb does this also affect 1.18? We will need a backport for that branch as well, it's still supported. (edit: bug confirms it is 1.19/1.20 only)

Please add a release note.

/priority important-soon
/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 23, 2021
@ehashman ehashman moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 23, 2021
@ehashman
Copy link
Member

/assign @klueska

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 23, 2021

/retest

@klueska
Copy link
Contributor

klueska commented Feb 23, 2021

Did the change I reviewed for 1.20 apply cleanly, or were there any merge conflicts that needed to be resolved in the backport?

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 23, 2021

@ehashman original PR lacks release note. Should I add some anyway?
@klueska the change applied cleanly.

@klueska
Copy link
Contributor

klueska commented Feb 24, 2021

Thanks for confirming

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iwankgb, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 25, 2021

/test pull-kubernetes-e2e-kind

2 similar comments
@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 25, 2021

/test pull-kubernetes-e2e-kind

@iwankgb
Copy link
Contributor Author

iwankgb commented Feb 25, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 25, 2021
@ehashman ehashman moved this from Needs Reviewer to Done in SIG Node PR Triage Mar 2, 2021
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 11, 2021
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

/test pull-kubernetes-node-e2e
/test pull-kubernetes-e2e-kind

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

/test pull-kubernetes-node-e2e

1 similar comment
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

/test pull-kubernetes-node-e2e

@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

/retest

1 similar comment
@iwankgb
Copy link
Contributor Author

iwankgb commented Mar 11, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit ae9d413 into kubernetes:release-1.19 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@klueska klueska Awaiting requested review from klueska

Assignees

@klueska klueska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@iwankgb @k8s-ci-robot @ehashman @klueska @fejta-bot @feiskyer @AlexeyPerevalov