Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump debian-base to v1.4.0 and debian-iptables to v1.5.0 #98526

Merged
merged 1 commit into from Jan 28, 2021
Merged

Bump debian-base to v1.4.0 and debian-iptables to v1.5.0 #98526

merged 1 commit into from Jan 28, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 28, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:
Both images are now sane multi-architecture images and should fix the
kube-proxy container image in the same way.
Which issue(s) this PR fixes:

Fixes #98229

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed kube-proxy container image architecture for non amd64 images.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@saschagrunert
Bump debian-base to v1.4.0 and debian-iptables to v1.5.0
1acaf32 
Both images are now sane multi-architecture images and should fix the
kube-proxy container image in the same way.

Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 28, 2021
@saschagrunert
Copy link
Member Author

cc @kubernetes/release-engineering

@saschagrunert
Copy link
Member Author

/assign @justaugustus
/sig release

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 28, 2021
@saschagrunert
Copy link
Member Author

/milestone v1.21
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 28, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 28, 2021
@justaugustus
Copy link
Member

Thanks Sascha!
/lgtm
/approve
/assign @jpbetz @wenjiaswe @mkumatag

FYI @dims

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021
cpanato
cpanato approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacoxu
Copy link
Member

pacoxu commented Jan 28, 2021

/lgtm

@mkumatag
Copy link
Member

/lgtm
/approve

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-bazel-test

hasheddan
hasheddan approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented Jan 28, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, hasheddan, justaugustus, mkumatag, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 90ca7e8 into kubernetes:master Jan 28, 2021
@saschagrunert saschagrunert deleted the debian-images branch January 28, 2021 15:01
@justaugustus justaugustus mentioned this pull request Jan 29, 2021
Merged
@justaugustus
Copy link
Member

etcd image promotion PR: kubernetes/k8s.io#1591

dghubble added a commit to poseidon/kubelet that referenced this pull request Jan 29, 2021
@dghubble
Update debian-iptables base from v1.3.0 to v1.5.0
33444ce 
* kubernetes/kubernetes#98401
* kubernetes/release#1877
* kubernetes/kubernetes#98526
@dghubble dghubble mentioned this pull request Jan 29, 2021
Merged
@mengjiao-liu mengjiao-liu mentioned this pull request Feb 1, 2021
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2021
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
@pacoxu pacoxu mentioned this pull request Mar 4, 2021
Merged
puerco added a commit to puerco/kubernetes that referenced this pull request Mar 17, 2021
@puerco
Bump debian-base to v1.4.0 and debian-iptables to v1.5.0
8829d03 
Backport of kubernetes#98526 to `release-1.20`.

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@pacoxu pacoxu mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

@jpbetz jpbetz Awaiting requested review from jpbetz

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@jpbetz jpbetz

@justaugustus justaugustus

@pacoxu pacoxu

@cpanato cpanato

@mkumatag mkumatag

@hasheddan hasheddan

@wenjiaswe wenjiaswe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Non amd64 kube-proxy container images have the wrong manifest architecture