Migrate `pkg/kubelet/lifecycle,oom` to structured logging #99479

mengjiao-liu · 2021-02-26T03:42:32Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For Structured Logging Migration: kubernetes/enhancements#1602
Migrate pkg/kubelet/lifecycle,oom to structured logging

Which issue(s) this PR fixes:

Ref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2021-02-26T03:42:40Z

Hi @mengjiao-liu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mengjiao-liu · 2021-02-26T05:42:59Z

/priority important-soon

mengjiao-liu · 2021-02-26T05:46:01Z

/sig instrumentation
/sig node

pacoxu · 2021-02-26T10:26:17Z

/ok-to-test

mengjiao-liu · 2021-02-26T10:54:30Z

/retest

mengjiao-liu · 2021-02-26T14:47:22Z

/retest

adisky · 2021-02-26T17:41:19Z

/triage accepted

yuzhiquan · 2021-03-06T03:43:26Z

/lgtm

ehashman

/lgtm cancel
/cc @serathius

pkg/kubelet/lifecycle/handlers.go

pkg/kubelet/lifecycle/predicate.go

ehashman · 2021-03-08T22:10:46Z

pkg/kubelet/lifecycle/predicate.go

@@ -110,7 +110,7 @@ func (w *predicateAdmitHandler) Admit(attrs *PodAdmitAttributes) PodAdmitResult
 		fit = len(reasons) == 0 && err == nil
 		if err != nil {
 			message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err)


Suggested change

message := fmt.Sprintf("Unexpected error while attempting to recover from admission failure: %v", err)

Same as above

pkg/kubelet/lifecycle/predicate.go

ehashman · 2021-03-08T22:13:48Z

Sorry for the back and forth, I think this is my first full review of this CL!

mengjiao-liu · 2021-03-11T04:02:31Z

/test pull-kubernetes-unit

mengjiao-liu · 2021-03-11T04:33:49Z

/test pull-kubernetes-unit

Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>

kikisdeliveryservice

All requested changes made (excluding message deletion which is used later in file), author also updated all logs in selected files, changes look good.

/lgtm

ehashman · 2021-03-11T23:54:18Z

/milestone v1.21

mrunalp · 2021-03-11T23:56:54Z

/approve

k8s-ci-robot · 2021-03-11T23:57:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengjiao-liu, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/kubelet/OWNERS~~ [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2021

k8s-ci-robot requested review from dims and sjenning February 26, 2021 03:43

k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 26, 2021

mengjiao-liu force-pushed the migrate_to_structured_logs branch from 298021d to 4fcf9e6 Compare February 26, 2021 05:31

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2021

k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Feb 26, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2021

mengjiao-liu force-pushed the migrate_to_structured_logs branch from 84623bb to 94fd6c0 Compare February 26, 2021 10:53

adisky added this to Triage in SIG Node PR Triage Feb 26, 2021

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 26, 2021

ehashman mentioned this pull request Mar 4, 2021

Kubelet migration to structured logs #98976

Closed

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2021

ehashman reviewed Mar 8, 2021

View reviewed changes

k8s-ci-robot requested a review from serathius March 8, 2021 22:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021

mengjiao-liu force-pushed the migrate_to_structured_logs branch from 9735ef7 to acb397f Compare March 11, 2021 03:19

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2021

Migrate pkg/kubelet/lifecycle,oom to structured logging

e557f61

Co-authored-by: Elana Hashman <ehashman@users.noreply.github.com>

mengjiao-liu force-pushed the migrate_to_structured_logs branch from acb397f to e557f61 Compare March 11, 2021 05:37

kikisdeliveryservice reviewed Mar 11, 2021

View reviewed changes

k8s-ci-robot assigned kikisdeliveryservice Mar 11, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021

kikisdeliveryservice moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 11, 2021

kikisdeliveryservice moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 11, 2021

k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021

mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 11, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021

k8s-ci-robot merged commit bebb932 into kubernetes:master Mar 12, 2021

Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 12, 2021

mengjiao-liu mentioned this pull request Mar 12, 2021

REQUEST: New membership for mengjiao-liu kubernetes/org#2569

Closed

6 tasks

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `pkg/kubelet/lifecycle,oom` to structured logging #99479

Migrate `pkg/kubelet/lifecycle,oom` to structured logging #99479

mengjiao-liu commented Feb 26, 2021 •

edited by liggitt

k8s-ci-robot commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

pacoxu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

adisky commented Feb 26, 2021

yuzhiquan commented Mar 6, 2021

ehashman left a comment

ehashman Mar 8, 2021

mengjiao-liu Mar 9, 2021

ehashman commented Mar 8, 2021

mengjiao-liu commented Mar 11, 2021

mengjiao-liu commented Mar 11, 2021

kikisdeliveryservice left a comment

ehashman commented Mar 11, 2021

mrunalp commented Mar 11, 2021

k8s-ci-robot commented Mar 11, 2021

Migrate pkg/kubelet/lifecycle,oom to structured logging #99479

Migrate pkg/kubelet/lifecycle,oom to structured logging #99479

Conversation

mengjiao-liu commented Feb 26, 2021 • edited by liggitt

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

pacoxu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

mengjiao-liu commented Feb 26, 2021

adisky commented Feb 26, 2021

yuzhiquan commented Mar 6, 2021

ehashman left a comment

Choose a reason for hiding this comment

ehashman Mar 8, 2021

Choose a reason for hiding this comment

mengjiao-liu Mar 9, 2021

Choose a reason for hiding this comment

ehashman commented Mar 8, 2021

mengjiao-liu commented Mar 11, 2021

mengjiao-liu commented Mar 11, 2021

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

ehashman commented Mar 11, 2021

mrunalp commented Mar 11, 2021

k8s-ci-robot commented Mar 11, 2021

Migrate `pkg/kubelet/lifecycle,oom` to structured logging #99479

Migrate `pkg/kubelet/lifecycle,oom` to structured logging #99479

mengjiao-liu commented Feb 26, 2021 •

edited by liggitt