Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resize Azure disk issue when it's in attached state #96705

Merged
merged 1 commit into from Nov 20, 2020
Merged

fix: resize Azure disk issue when it's in attached state #96705

merged 1 commit into from Nov 20, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Nov 19, 2020 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: resize Azure disk issue when it's in attached state

This PR would return error directly when disk is in attached state

Which issue(s) this PR fixes:

Fixes #96706

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: resize Azure disk issue when it's in attached state

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: resize Azure disk issue when it's in attached state

/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
/kind bug
/assign @feiskyer

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 19, 2020
@andyzhangx
Copy link
Member Author

/hold
hold a while for test pass

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 19, 2020
@andyzhangx
Copy link
Member Author

/retest

feiskyer
feiskyer reviewed Nov 19, 2020
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/azure/azure_managedDiskController.go Outdated
@@ -297,6 +297,10 @@ func (c *ManagedDiskController) ResizeDisk(diskURI string, oldSize resource.Quan
return newSizeQuant, nil
}

if result.DiskProperties.DiskState != compute.Unattached {
return oldSize, fmt.Errorf("azureDisk - disk resize is only supported on Unattached disk, current disk state: %s", result.DiskProperties.DiskState)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to log the attached VM information as a warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added attached VM info in the error msg, it would be in logs finally

@andyzhangx
Copy link
Member Author

/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
feiskyer
feiskyer reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure 0d38026 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 7d72ddc into kubernetes:master Nov 20, 2020
This was referenced Nov 20, 2020
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2020
@k8s-ci-robot
Merge pull request #96738 from andyzhangx/automated-cherry-pick-of-#9…
7ef8b18 
…6705-upstream-release-1.19

Automated cherry pick of #96705: fix: resize Azure disk issue when it's in attached state
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2020
@k8s-ci-robot
Merge pull request #96740 from andyzhangx/automated-cherry-pick-of-#9…
4d094d5 
…6705-upstream-release-1.17

Automated cherry pick of #96705: fix: resize Azure disk issue when it's in attached state
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2020
@k8s-ci-robot
Merge pull request #96739 from andyzhangx/automated-cherry-pick-of-#9…
3d4f0e3 
…6705-upstream-release-1.18

Automated cherry pick of #96705: fix: resize Azure disk issue when it's in attached state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

resize Azure disk issue when it's in attached state
3 participants
@andyzhangx @k8s-ci-robot @feiskyer