Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix #97621

Merged
merged 2 commits into from Jan 6, 2021
Merged

Bug fix #97621

merged 2 commits into from Jan 6, 2021

Conversation

vbannai
Copy link
Contributor

@vbannai vbannai commented Dec 30, 2020 •
edited by liggitt

What type of PR is this?
/kind bug

What this PR does / why we need it:
Updates the container image for default http back for ingress to a new version of the container images which does expose metrics endpoint.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updated k8s.gcr.io/ingress-gce-404-server-with-metrics-amd64 to a version that serves /metrics endpoint on a non-default port.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@vbannai
The l7-default-backend/defult-http-backend now points to a new versio…
a15bc59 
…n of the 404-server-with-metrics.

Uses new container registry: gcr.io/google-container with the new version for the ingress-gce-404-server-with-metrics-amd64:v1.10.11
@vbannai
Updating the version to the recent tag.
e74ef53
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 30, 2020
@k8s-ci-robot
Copy link
Contributor

@vbannai: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @vbannai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 30, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 30, 2020
@freehan
Copy link
Contributor

freehan commented Jan 5, 2021

/lgtm
/approve

@freehan
Copy link
Contributor

freehan commented Jan 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, vbannai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 97a3e9e into kubernetes:master Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 6, 2021
jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 2, 2021
@vbannai
The l7-default-backend/defult-http-backend now points to a new versio…
d820b56 
…n of the 404-server-with-metrics.

Uses new container registry: gcr.io/google-container with the new version for the ingress-gce-404-server-with-metrics-amd64:v1.10.11

BUG=b/176869895

Cherrypicks: kubernetes#97621

Change-Id: I58d251e2dafcee79c72f2eb3b39ed366551189c7
jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 2, 2021
@vbannai
Updating the version to the recent tag.
50d0f9a 
BUG=b/176869895

Cherrypicks: kubernetes#97621

Change-Id: Ib15ba7013b8201dd26203cd4c6e6d18631e63e5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbannai @k8s-ci-robot @freehan