Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #104009: delete stale UDP conntrack entries for loadbalancer IPs #104151

Merged
merged 1 commit into from Aug 16, 2021
Merged

Automated cherry pick of #104009: delete stale UDP conntrack entries for loadbalancer IPs #104151

merged 1 commit into from Aug 16, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 5, 2021 •
edited

Cherry pick of #104009 on release-1.21.

#104009: delete stale UDP conntrack entries for loadbalancer IPs

For details on the cherry pick process, see the cherry pick requests page.

kube-proxy: delete stale conntrack UDP entries for loadbalancer ingress IP.

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2021
@aojea aojea mentioned this pull request Aug 5, 2021
Merged
@aojea aojea force-pushed the automated-cherry-pick-of-#104009-upstream-release-1.21 branch from 76e25ce to 78261b0 Compare August 8, 2021 19:44
@aojea
Copy link
Member Author

aojea commented Aug 8, 2021

/sig network
/kind bug
/assign @thockin @danwinship
ping @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 8, 2021
@aojea
Copy link
Member Author

aojea commented Aug 9, 2021

/assign @bowei
we should have 1.21 before 1.20

@aojea
Copy link
Member Author

aojea commented Aug 10, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 10, 2021
@bowei
Copy link
Member

bowei commented Aug 12, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2021
@ialidzhikov
Copy link
Contributor

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team August 12, 2021 12:24
@thockin
Copy link
Member

thockin commented Aug 13, 2021

Thanks!

/lgtm
/approve

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2021
@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 16, 2021
@cpanato cpanato removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2021
cpanato
cpanato approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from RelEng:
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, bowei, cpanato, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Aug 16, 2021

/test pull-kubernetes-e2e-kind

k8s-ci-robot added a commit that referenced this pull request Aug 16, 2021
@k8s-ci-robot
Merge pull request #104152 from aojea/automated-cherry-pick-of-#10415…
b1821f0 
…1-upstream-release-1.20

Automated cherry pick of #104151: delete stale UDP conntrack entries for loadbalancer IPs
@k8s-ci-robot k8s-ci-robot merged commit d0d5554 into kubernetes:release-1.21 Aug 16, 2021
@aojea aojea mentioned this pull request Sep 22, 2021
Closed
@uablrek uablrek mentioned this pull request Sep 25, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@danwinship danwinship

@bowei bowei

@cpanato cpanato

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aojea @bowei @ialidzhikov @thockin @cpanato @k8s-ci-robot @danwinship