Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AttachVolumeLimit feature gate #96539

Merged
merged 1 commit into from Jan 4, 2021
Merged

Remove AttachVolumeLimit feature gate #96539

merged 1 commit into from Jan 4, 2021

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Nov 12, 2020 •
edited

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change?:

The `AttachVolumeLimit` feature gate that is GA since v1.17 is now removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/issues/554

@ialidzhikov
Remove AttachVolumeLimit feature gate
f6f43ad 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2020
@ialidzhikov
Copy link
Contributor Author

/sig storage
/cc @bertinatto

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2020
@dims
Copy link
Member

dims commented Nov 14, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
bertinatto
bertinatto reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@ialidzhikov
Copy link
Contributor Author

/cc @gnufied

@gnufied , can you approve so that we proceed with the cleanup of the feature?

@gnufied
Copy link
Member

gnufied commented Dec 9, 2020

Yeah looks fine to me.

/lgtm

@ialidzhikov
Copy link
Contributor Author

Can we proceed with getting this PR in?

@gnufied
Copy link
Member

gnufied commented Dec 15, 2020

assigning to saad for approving feature gate changes.

/assign @saad-ali

@ialidzhikov
Copy link
Contributor Author

/cc @msau42

@dims
Copy link
Member

dims commented Jan 4, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@ialidzhikov
Copy link
Contributor Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 564ffbd into kubernetes:master Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 4, 2021
@github-actions github-actions bot mentioned this pull request Jan 5, 2021
Open
@ialidzhikov ialidzhikov deleted the cleanup/attach-volume-limit branch January 9, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@dims dims Awaiting requested review from dims

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@gnufied gnufied Awaiting requested review from gnufied

@msau42 msau42 Awaiting requested review from msau42

Assignees

@gnufied gnufied

@bertinatto bertinatto

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ialidzhikov @k8s-ci-robot @dims @gnufied @bertinatto @saad-ali