New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #106891: kubeadm: validate local etcd certficates during #106925
Merged
k8s-ci-robot
merged 2 commits into
kubernetes:release-1.22
from
neolit123:automated-cherry-pick-of-#106891-origin-release-1.22
Dec 10, 2021
Merged
Automated cherry pick of #106891: kubeadm: validate local etcd certficates during #106925
k8s-ci-robot
merged 2 commits into
kubernetes:release-1.22
from
neolit123:automated-cherry-pick-of-#106891-origin-release-1.22
Dec 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case stacked etcd is used, the code that does expiration checks does not validate if the etcd CA is "external" (missing key) and if the etcd CA signed certificates are valid. Add a new function UsingExternalEtcdCA() similar to existing functions for the cluster CA and front-proxy CA, that performs the checks for missing etcd CA key and certificate validity. This function only runs for stacked etcd, since if etcd is external kubeadm does not track any certs signed by that etcd CA. This fixes a bug where the etcd CA will be reported as local even if the etcd/ca.key is missing during "certs check-expiration".
Apply a small fix to ensure the kubeconfig files that kubeadm manages have a CA when printed in the table of the "check expiration" command. "CAName" is the field used for that. In practice kubeconfig files can contain multiple credentials from different CAs, but this is not supported by kubeadm and there is a single cluster CA that signs the single client cert/key in kubeadm managed kubeconfigs.
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
do-not-merge/needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Dec 9, 2021
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
labels
Dec 9, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
do-not-merge/needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Dec 9, 2021
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 10, 2021
/lgtm |
Thanks @neolit123 ! |
puerco
added
the
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
label
Dec 10, 2021
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Indicates that a PR is not yet approved to merge into a release branch.
label
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/kubeadm
cherry-pick-approved
Indicates a cherry-pick PR into a release branch has been approved by the release branch manager.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #106891 on release-1.22.
#106891: kubeadm: validate local etcd certficates during
For details on the cherry pick process, see the cherry pick requests page.