Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smb mount PermissionDenied issue on Windows #99550

Merged
merged 1 commit into from Mar 3, 2021
Merged

fix smb mount PermissionDenied issue on Windows #99550

merged 1 commit into from Mar 3, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix smb mount PermissionDenied issue on Windows

issue details could be found here: moby/moby#37863

Just use the -RequirePrivacy $true along with the New-SMBGlobalMapping.

MUP cache seems to be a problem here. The MUP cache clears every 15 minutes and the credentials to the SMB File Share are not saved.

New commands looks like - New-SMBGlobalMapping -RemotePath \contosofileserver\share1 -LocalPath G: -RequirePrivacy $true

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix smb mount PermissionDenied issue on Windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix smb mount PermissionDenied issue on Windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2021
@andyzhangx andyzhangx mentioned this pull request Feb 28, 2021
Closed
@andyzhangx
Copy link
Member Author

/kind bug
/assign @jingxu97
/priority important-soon
/triage accepted

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 28, 2021
@andyzhangx
Copy link
Member Author

/sig cloud-provider
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2021
@andyzhangx
Copy link
Member Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Feb 28, 2021
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@andyzhangx
Copy link
Member Author

/retest

2 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

@jingxu97 could you approve? thanks.

@jingxu97
Copy link
Contributor

jingxu97 commented Mar 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@jingxu97
Copy link
Contributor

jingxu97 commented Mar 2, 2021

Just want to confirm should we always use this -RequirePrivacy $true. Will this cause any issue for some use cases?

@andyzhangx
Copy link
Member Author

Just want to confirm should we always use this -RequirePrivacy $true. Will this cause any issue for some use cases?

according to moby/moby#37863 (comment), we should always set -RequirePrivacy $true

@andyzhangx
Copy link
Member Author

andyzhangx commented Mar 3, 2021 •
edited

@jingxu97 I will cherry-pick to old releases and csi-proxy when this PR got merged, could you lgtm? thanks.

@jingxu97
Copy link
Contributor

jingxu97 commented Mar 3, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2021
@jingxu97
Copy link
Contributor

jingxu97 commented Mar 3, 2021

@andyzhangx should we do the same change for csi-proxy too?

@andyzhangx
Copy link
Member Author

@andyzhangx should we do the same change for csi-proxy too?

yes

@k8s-ci-robot k8s-ci-robot merged commit 716a054 into kubernetes:master Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 3, 2021
This was referenced Mar 3, 2021
Merged
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request May 7, 2021
@k8s-ci-robot
Merge pull request #99705 from andyzhangx/automated-cherry-pick-of-#9…
0472369 
…9550-upstream-release-1.20

Automated cherry pick of #99550: fix smb mount issue on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyzhangx @jingxu97 @k8s-ci-robot