Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/Azure/go-autorest/autorest to v0.11.12 #97033

Merged
merged 2 commits into from Dec 17, 2020
Merged

Bump github.com/Azure/go-autorest/autorest to v0.11.12 #97033

merged 2 commits into from Dec 17, 2020

Conversation

patrickshan
Copy link
Contributor

@patrickshan patrickshan commented Dec 3, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Bump github.com/Azure/go-autorest/autorest to v0.11.12 to address https://nvd.nist.gov/vuln/detail/CVE-2020-26160.
Similar to #95692, this update bumps github.com/Azure/go-autorest/autorest. At the moment the version in current master still depends on github.com/dgrijalva/jwt-go v3.2.0 which is vulnerable to
CVE-2020-26160.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

Bump github.com/Azure/go-autorest/autorest to v0.11.12

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @patrickshan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from soltysh, yliaog and a team December 3, 2020 04:46
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 3, 2020
@patrickshan patrickshan mentioned this pull request Dec 3, 2020
Closed
@fedebongio
Copy link
Contributor

/assign @yliaog
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 3, 2020
@yliaog
Copy link
Contributor

yliaog commented Dec 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/apiserver area/cloudprovider area/kubectl and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2020
@patrickshan
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 4, 2020
@liggitt
Copy link
Member

liggitt commented Dec 4, 2020

the version in current master still depends on github.com/dgrijalva/jwt-go v3.2.0

I don't object to updating the dependency if the azure maintainers approve of this change, but to be clear, kubernetes does not make use of the code in Azure/go-autorest/autorest that depends on github.com/dgrijalva/jwt-go (as evidenced by this PR not changing any go files in vendor that reference github.com/dgrijalva/jwt-go).

@patrickshan
Copy link
Contributor Author

patrickshan commented Dec 7, 2020 •
edited

@liggitt do I need to ping a specific sig to get azure maintainers to review this ?

@liggitt
Copy link
Member

liggitt commented Dec 8, 2020 •
edited

sig-windows and/or sig-cloud-provider would be my recommendation

@patrickshan
Copy link
Contributor Author

patrickshan commented Dec 10, 2020 •
edited

Pinged sig-cloud-provider and sig-windows on Slack. Haven't got any response yet.

@ehashman
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Dec 16, 2020
@ehashman
Copy link
Member

/assign @cheftako

@ehashman
Copy link
Member

/area provider/azure

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Dec 16, 2020
@cheftako
Copy link
Member

FYI (I realize this does not appear to be a feature change)
Starting in v1.21, we are disallowing feature PRs into the built-in legacy cloud providers (i.e. k8s.io/legacy-cloud-providers). Any kind/feature PRs going forward will have to be approved by SIG Cloud Provider. See this mailing list thread for more details https://groups.google.com/g/kubernetes-sig-cloud-provider/c/UkG46pNc6Cw.

@cheftako
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020
@cheftako
Copy link
Member

/approve

@patrickshan
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Dec 17, 2020

/kind cleanup
/approve
for dependency mechanics

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, liggitt, patrickshan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e11e9d4 into kubernetes:master Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 17, 2020
This was referenced Dec 18, 2020
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jan 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@cheftako cheftako

@liggitt liggitt

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@patrickshan @k8s-ci-robot @fedebongio @yliaog @liggitt @ehashman @cheftako @fejta-bot