New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kube-scheduler cannot send event because the Note field is too large #98715
Conversation
@carlory: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c87d945
to
67cc31a
Compare
/assign @alculquicondor @gitirabassi It's ready for review. Any feedback is welcome. |
@carlory: GitHub didn't allow me to assign the following users: gitirabassi. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/scheduler/scheduler.go
Outdated
if err := updatePod(sched.client, pod, &v1.PodCondition{ | ||
Type: v1.PodScheduled, | ||
Status: v1.ConditionFalse, | ||
Reason: reason, | ||
Message: err.Error(), | ||
Message: msg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the pod message there shouldn't be any message size limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2559 (would be best to have the full message)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitirabassi reverted
67cc31a
to
c480e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add a release note |
c480e79
to
0b730f0
Compare
/test pull-kubernetes-bazel-build |
@alculquicondor It's ready for review |
/approve please submit a cherry-pick request to all supported versions https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, carlory, gitirabassi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@alculquicondor thanks for your guide, I will submit a cherry-pick request later. |
…5-upstream-release-1.20 Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
…5-upstream-release-1.18 Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
…5-upstream-release-1.19 Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
What type of PR is this?
/kind bug
What this PR does / why we need it:
I would expect the Kube-scheduler to be able to send the event no matter how many different taints are on nodes
Which issue(s) this PR fixes:
Fixes #98175
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: