Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kube-scheduler cannot send event because the Note field is too large #98715

Merged
merged 1 commit into from Feb 4, 2021
Merged

fix kube-scheduler cannot send event because the Note field is too large #98715

merged 1 commit into from Feb 4, 2021

Conversation

carlory
Copy link
Member

@carlory carlory commented Feb 3, 2021 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

I would expect the Kube-scheduler to be able to send the event no matter how many different taints are on nodes

Which issue(s) this PR fixes:

Fixes #98175

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

truncates a message if it hits the NoteLengthLimit when the scheduler records an event for the pod that indicates the pod has failed to schedule.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

@carlory: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2021
@carlory carlory changed the title [WIP] fix kube-scheduler cannot send event because the Note field is too large fix kube-scheduler cannot send event because the Note field is too large Feb 3, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2021
@carlory
Copy link
Member Author

carlory commented Feb 3, 2021

/assign @alculquicondor @gitirabassi

It's ready for review. Any feedback is welcome.

@k8s-ci-robot
Copy link
Contributor

@carlory: GitHub didn't allow me to assign the following users: gitirabassi.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @alculquicondor @gitirabassi

It's ready for review. Any feedback is welcome.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gitirabassi
gitirabassi reviewed Feb 3, 2021
View reviewed changes
pkg/scheduler/scheduler.go Outdated
if err := updatePod(sched.client, pod, &v1.PodCondition{
Type: v1.PodScheduled,
Status: v1.ConditionFalse,
Reason: reason,
Message: err.Error(),
Message: msg,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the pod message there shouldn't be any message size limit

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2559 (would be best to have the full message)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitirabassi reverted

gitirabassi
gitirabassi approved these changes Feb 3, 2021
View reviewed changes
Copy link

@gitirabassi gitirabassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alculquicondor
Copy link
Member

Please add a release note

alculquicondor
alculquicondor reviewed Feb 3, 2021
View reviewed changes
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 4, 2021
@carlory
Copy link
Member Author

carlory commented Feb 4, 2021

/test pull-kubernetes-bazel-build

@carlory
Copy link
Member Author

carlory commented Feb 4, 2021

@alculquicondor It's ready for review

@alculquicondor
Copy link
Member

/approve
/lgtm

please submit a cherry-pick request to all supported versions https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, carlory, gitirabassi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@alculquicondor
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3416b6b into kubernetes:master Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
@carlory
Copy link
Member Author

carlory commented Feb 5, 2021 •
edited

@alculquicondor thanks for your guide, I will submit a cherry-pick request later.

This was referenced Feb 5, 2021
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 6, 2021
@k8s-ci-robot
Merge pull request #98794 from carlory/automated-cherry-pick-of-#9871…
af0ce4d 
…5-upstream-release-1.20

Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
k8s-ci-robot added a commit that referenced this pull request Feb 6, 2021
@k8s-ci-robot
Merge pull request #98798 from carlory/automated-cherry-pick-of-#9871…
3260181 
…5-upstream-release-1.18

Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
k8s-ci-robot added a commit that referenced this pull request Feb 6, 2021
@k8s-ci-robot
Merge pull request #98795 from carlory/automated-cherry-pick-of-#9871…
2148d77 
…5-upstream-release-1.19

Automated cherry pick of #98715: fix kube-scheduler cannot send event because the Note field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@gitirabassi gitirabassi gitirabassi approved these changes

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Kube-scheduler can't send event because Note field too large
4 participants
@carlory @k8s-ci-robot @alculquicondor @gitirabassi