Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update cAdvisor to v0.37.4 #98015

Merged
merged 1 commit into from Jan 19, 2021
Merged

vendor: update cAdvisor to v0.37.4 #98015

merged 1 commit into from Jan 19, 2021

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Jan 13, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR is needed to bump the cAdvisor version to v0.37.4 which fixes an issue that the kubelet cannot start on BtrfS

cadvisor PR: google/cadvisor#2752

Which issue(s) this PR fixes:

Fixes #94335

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed a bug that the kubelet cannot start on BtrfS.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

@gjkim42: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @gjkim42. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jan 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from lavalamp, thockin and a team January 13, 2021 10:33
@gjkim42
Copy link
Member Author

gjkim42 commented Jan 13, 2021

/cc @bobbypage

@bobbypage
Copy link
Member

This is missing the vendored changes.

The general process to vendor is following, I'm guessing you also need to run hack/update-vendor.sh. More details here

$ hack/pin-dependency.sh github.com/google/cadvisor ${NEW-CADVISOR_VERSION_TAG}
$ hack/update-vendor.sh
$ hack/lint-dependencies.sh # should come back empty, if not run hack/pin-dependency.sh for each listed dep and re-vendor
$ hack/verify-vendor.sh

@ehashman
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Jan 14, 2021

fixed the vendored changes!

@ehashman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2021
@ehashman ehashman mentioned this pull request Jan 14, 2021
Merged
@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@bobbypage
Copy link
Member

bobbypage commented Jan 14, 2021 •
edited

/assign @dims for deps approval

@ehashman ehashman added this to Needs Approver in SIG Node PR Triage Jan 14, 2021
hasheddan
hasheddan approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ehashman
Copy link
Member

/assign @liggitt

can you please give a deps approval so this and #98014 stay in sync? :)

@hasheddan
Copy link
Contributor

@ehashman just a note, we will never (intentionally) cp approve on one branch before the others are also ready :)

@liggitt
Copy link
Member

liggitt commented Jan 19, 2021

/approve
for deps

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, hasheddan, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 19, 2021
@bobbypage
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 872d93f into kubernetes:release-1.19 Jan 19, 2021
SIG Node PR Triage automation moved this from Needs Approver to Done Jan 19, 2021
@gjkim42 gjkim42 deleted the vendor-cadvisor-v0.37.4 branch January 23, 2021 01:45
@github-actions github-actions bot mentioned this pull request Jan 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@thockin thockin Awaiting requested review from thockin

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@dims dims

@bobbypage bobbypage

@liggitt liggitt

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gjkim42 @k8s-ci-robot @bobbypage @ehashman @hasheddan @liggitt @dims