Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #98254 for 1.19: Fix the kube-scheduler binary's descr… #98873

Merged
merged 1 commit into from Feb 12, 2021
Merged

Cherry pick of #98254 for 1.19: Fix the kube-scheduler binary's descr… #98873

merged 1 commit into from Feb 12, 2021

Conversation

changshuchao
Copy link
Contributor

@changshuchao changshuchao commented Feb 8, 2021 •
edited

Cherry pick of #98254 on release-1.19.

#98254:Fix the kube-scheduler binary's description of the --config parameter is inaccurate

Does this PR introduce a user-facing change?:

Fix the description of command line flags that can override --config

/kind bug

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

@changshuchao: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @changshuchao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 8, 2021
@changshuchao changshuchao mentioned this pull request Feb 8, 2021
Merged
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2021
@alculquicondor
Copy link
Member

@damemi could you verify if this applies to 1.19 as is?

@damemi
Copy link
Contributor

damemi commented Feb 8, 2021

I'm not aware of any other changes between 1.19-1.20 that would affect this list. @changshuchao you seemed to have extensively tested all of these flags in your main PR, is the list the same for 1.19?

damemi
damemi reviewed Feb 8, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2021
@changshuchao
Cherry pick of kubernetes#98254 for 1.19: Fix the kube-scheduler bina…
fc5aace 
…ry's description of the --config parameter is inaccurate

Signed-off-by: changshuchao <chang.shuchao1@zte.com.cn>
@changshuchao
Copy link
Contributor Author

I'm not aware of any other changes between 1.19-1.20 that would affect this list. @changshuchao you seemed to have extensively tested all of these flags in your main PR, is the list the same for 1.19?

Yes, I have checked the relevant code

@changshuchao
Copy link
Contributor Author

/retest

hasheddan
hasheddan reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/assign @damemi

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 12, 2021
damemi
damemi reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@alculquicondor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, changshuchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 12, 2021
@alculquicondor
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 66f4806 into kubernetes:release-1.19 Feb 12, 2021
@changshuchao changshuchao deleted the cherry-pick-of-scheduler-1-19 branch February 18, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@hasheddan hasheddan hasheddan left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@changshuchao @k8s-ci-robot @alculquicondor @damemi @hasheddan