Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cAdvisor json metrics collected by Kubelet #99236

Merged
merged 1 commit into from Mar 2, 2021
Merged

Deprecate cAdvisor json metrics collected by Kubelet #99236

merged 1 commit into from Mar 2, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 19, 2021 •
edited

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

/sig node
refer to the KEP

Which issue(s) this PR fixes:

implement kubernetes/enhancements#2129
part of #86843

Special notes for your reviewer:

Some information from the KEP, to make it clear which should be removed.

Goals

  • Remove cAdvisor v1 ContainerInfo json metrics (/stats/container, /stats/<podname>/<containername>, /stats/<namespace>/<podname>/<poduid>/<containername>) from the kubelet.
  • Remove cAdvisor v1 MachineInfo json metrics (/spec) from the kubelet.

Non-Goals

  • Remove or modify cadvisor prometheus metrics from the kubelet (/metrics/prometheus).
  • Remove or modify the Summary API
  • Eliminate the kubelet's dependence on cAdvisor for metrics to supply the Summary API.

Does this PR introduce a user-facing change?

remove cAdvisor json metrics api collected by Kubelet

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:  https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2129-remove-cadvisor-json-metrics

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 19, 2021
@pacoxu pacoxu changed the title deprecate cAdvisor json metrics collected by Kubelet [wip]deprecate cAdvisor json metrics collected by Kubelet Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2021
@pacoxu pacoxu force-pushed the enable-cadvisor-json-endpoints/cleanup branch 2 times, most recently from 17aaf34 to 4c880e0 Compare February 20, 2021 03:49
@pacoxu
Copy link
Member Author

pacoxu commented Feb 20, 2021

/triage accepted
/priority important-soon
(since the KEP is marked to be done in 1.21)

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 20, 2021
@pacoxu pacoxu force-pushed the enable-cadvisor-json-endpoints/cleanup branch 3 times, most recently from 4ec414b to 2b90608 Compare February 20, 2021 07:05
@pacoxu
Copy link
Member Author

pacoxu commented Feb 20, 2021

/retest

@pacoxu pacoxu changed the title [wip]deprecate cAdvisor json metrics collected by Kubelet Deprecate cAdvisor json metrics collected by Kubelet Feb 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 20, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 20, 2021

/cc @dashpole
I think it is almost done.

@dashpole
Copy link
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 28, 2021

/assign @mrunalp
for approval

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 1, 2021

Needs rebase.

@pacoxu pacoxu force-pushed the enable-cadvisor-json-endpoints/cleanup branch from 044ab00 to 0b24f6f Compare March 2, 2021 01:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Mar 2, 2021 •
edited

@mrunalp
Rebased. Would you take a look again? Thanks.

@pacoxu
Copy link
Member Author

pacoxu commented Mar 2, 2021

/remove-label needs-rebase

@k8s-ci-robot
Copy link
Contributor

@pacoxu: The label(s) /remove-label needs-rebase cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/remove-label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu pacoxu force-pushed the enable-cadvisor-json-endpoints/cleanup branch from 0b24f6f to 1241891 Compare March 2, 2021 02:12
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2021
@pacoxu
deprecate cAdvisor json metrics collected by Kubelet
cd54bd9 
- remove unused code for cadvisor json metrics collected

Signed-off-by: pacoxu <paco.xu@daocloud.io>
@pacoxu pacoxu force-pushed the enable-cadvisor-json-endpoints/cleanup branch from 1241891 to cd54bd9 Compare March 2, 2021 07:37
@pacoxu
Copy link
Member Author

pacoxu commented Mar 2, 2021

rebased again 😓

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Mar 2, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit ec1b6ce into kubernetes:master Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 2, 2021
@arunmk arunmk mentioned this pull request Mar 2, 2021
Closed
4 tasks
This was referenced Mar 10, 2021
Merged
Merged
@pacoxu pacoxu deleted the enable-cadvisor-json-endpoints/cleanup branch June 23, 2021 05:42
@tallclair tallclair mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@dashpole dashpole Awaiting requested review from dashpole

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@ehashman ehashman Awaiting requested review from ehashman

Assignees

@mrunalp mrunalp

@dashpole dashpole

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pacoxu @matthyx @dashpole @k8s-ci-robot @mrunalp @ehashman @dchen1107