Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node-problem-detector to v0.8.5 #96716

Merged
merged 1 commit into from Nov 21, 2020
Merged

Bump node-problem-detector to v0.8.5 #96716

merged 1 commit into from Nov 21, 2020

Conversation

tosi3k
Copy link
Member

@tosi3k tosi3k commented Nov 19, 2020 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
NPD v0.8.0 doesn't detect OOMs in newer Linux kernels. v0.8.5 contains a fix that enables the NPD to detect them in both older and newer kernels.

Which issue(s) this PR fixes:
Fixes #96746.

Special notes for your reviewer:
Holding since the Docker image for NPD v0.8.5 is not released yet.
/hold
/sig scalability
/assign @wojtek-t

SHA512 digest of the v0.8.5 tar package:

zawodny@zawodny  ~/Downloads  sha512sum node-problem-detector-v0.8.5.tar.gz
3fbf97a38c06d8fcc8c46f956a6e90aa1b47cb42d50ddcfd1a644a7e624e42ee523db2f81e08fbfb21b80142d4bafdbedce16e8b62d2274a5b2b703a56d9c015  node-problem-detector-v0.8.5.tar.gz

Does this PR introduce a user-facing change?:

Bump node-problem-detector version to v0.8.5 to fix OOM detection in with Linux kernels 5.1+

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

@tosi3k: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 19, 2020
invidian
invidian reviewed Nov 19, 2020
View reviewed changes
cluster/addons/node-problem-detector/npd.yaml Outdated
kubernetes.io/cluster-service: "true"
spec:
containers:
- name: node-problem-detector
image: k8s.gcr.io/node-problem-detector:v0.8.0
image: k8s.gcr.io/node-problem-detector:v0.8.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this image (or k8s.gcr.io/node-problem-detector/node-problem-detector:v0.8.5) is not yet available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's why I put this PR on hold in the first place :).

@harche
Copy link
Contributor

harche commented Nov 19, 2020

/test pull-kubernetes-node-crio-e2e

@harche harche mentioned this pull request Nov 19, 2020
Merged
@wojtek-t wojtek-t added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 20, 2020
@wojtek-t
Copy link
Member

@tosi3k - please open k/k issue for this one - this is a bug and I want this to land in 1.20 (and we should then cherrypick back)

@tosi3k tosi3k mentioned this pull request Nov 20, 2020
Closed
@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

@tosi3k - please open k/k issue for this one - this is a bug and I want this to land in 1.20 (and we should then cherrypick back)

Done - I updated the PR's description with the URL to the issue.

@wojtek-t
Copy link
Member

@tosi3k - was the image already built?

@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

@tosi3k - was the image already built?

Not yet, unfortunately :/. I will unhold the PR (and rerun the tests) once it's released.

@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

v0.8.5 is released:

 ~  docker pull k8s.gcr.io/node-problem-detector/node-problem-detector:v0.8.5
v0.8.5: Pulling from node-problem-detector/node-problem-detector
39fafc05754f: Already exists 
4ace085f408a: Already exists 
c9131edd1592: Pull complete 
7245b8152cc0: Pull complete 
f688a05461d1: Pull complete 
d5cffb7d7176: Pull complete 
Digest: sha256:07645e26231454292ddcd20863e8fe1a9422d0e9888bd1a1ff3189695e143138
Status: Downloaded newer image for k8s.gcr.io/node-problem-detector/node-problem-detector:v0.8.5
k8s.gcr.io/node-problem-detector/node-problem-detector:v0.8.5

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

/retest

@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

/test pull-kubernetes-e2e-kind-ipv6

@tosi3k
Copy link
Member Author

tosi3k commented Nov 20, 2020

@wojtek-t PTAL.

@wojtek-t
Copy link
Member

/lgtm
/approve

Adding to milestone as this is fixing a bug.
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 21, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2020
@wojtek-t
Copy link
Member

@tosi3k - once this merges, please cherrypick to previous releases

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kemooo3333, tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b2ecd1b into kubernetes:master Nov 21, 2020
This was referenced Nov 21, 2020
Merged
Merged
Merged
@ialidzhikov
Copy link
Contributor

@tosi3k - once this merges, please cherrypick to previous releases

v1.17 -#96783
v1.18 -#96784
v1.19 -#96785

k8s-ci-robot added a commit that referenced this pull request Nov 23, 2020
@k8s-ci-robot
Merge pull request #96783 from ialidzhikov/automated-cherry-pick-of-#…
edec69d 
…96716-upstream-release-1.17

Automated cherry pick of #96716: Bump node-problem-detector to v0.8.5
k8s-ci-robot added a commit that referenced this pull request Nov 23, 2020
@k8s-ci-robot
Merge pull request #96785 from ialidzhikov/automated-cherry-pick-of-#…
e79c5cb 
…96716-upstream-release-1.19

Automated cherry pick of #96716: Bump node-problem-detector to v0.8.5
k8s-ci-robot added a commit that referenced this pull request Nov 23, 2020
@k8s-ci-robot
Merge pull request #96784 from ialidzhikov/automated-cherry-pick-of-#…
6d21153 
…96716-upstream-release-1.18

Automated cherry pick of #96716: Bump node-problem-detector to v0.8.5
@github-actions github-actions bot mentioned this pull request Nov 24, 2020
Open
@tosi3k tosi3k deleted the bump-npd-to-v0.8.5 branch February 9, 2021 21:35
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invidian invidian invidian left review comments

@mm4tt mm4tt Awaiting requested review from mm4tt

@mml mml Awaiting requested review from mml

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

node-problem-detector does not discover OOMs in newer Linux kernels
6 participants
@tosi3k @k8s-ci-robot @harche @wojtek-t @ialidzhikov @invidian