Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of anp 0.0.27 for v1.21 #107188

Merged
merged 2 commits into from Jan 6, 2022
Merged

Cherry pick of anp 0.0.27 for v1.21 #107188

merged 2 commits into from Jan 6, 2022

Conversation

rata
Copy link
Member

@rata rata commented Dec 22, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates konnectivity-network-proxy to v0.0.27. This includes a memory leak fix for the network proxy

see: #106922

Cherry-picks of this fix to other release branches:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updates konnectivity-network-proxy to v0.0.27. This includes a memory leak fix for the network proxy

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 22, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 22, 2021
@k8s-ci-robot
Copy link
Contributor

@rata: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 22, 2021
@rata rata mentioned this pull request Dec 22, 2021
Merged
@rata
Copy link
Member Author

rata commented Dec 22, 2021

As with #107187 I'd like @cheftako or @jkh52 to take a look, just in case, as this is a bigger version jump.

I didn't test this locally as hack/local-up-cluster in this version doesn't know about env var EGRESS_SELECTOR_CONFIG_FILE to configure konnectivity. I guess there are e2e tests for this, though, right? (A quick grep on tests/ for konnectivity, network-proxy or anp didn't show anything). @cheftako @jkh52 probably you know?

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes labels Dec 22, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2021
@rata
Update to apiserver-network-proxy v0.0.27
16f25f7 
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
@rata
Update GCE manifest to use konnectivity v0.0.27
6c69596 
Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
@rata rata changed the title Cherry pick of anp 0.0.27 Cherry pick of anp 0.0.27 for v1.21 Dec 22, 2021
@rata
Copy link
Member Author

rata commented Dec 22, 2021

/retest

@jkh52
Copy link
Contributor

jkh52 commented Dec 22, 2021

Is it typical to cherry pick to several minor versions at the same time? Or, should release-1.21 be treated more conservative than -1.22 or -1.23?

@rata
Copy link
Member Author

rata commented Dec 23, 2021

@jkh52 It was requested by @xmudrii. They said they prefer to merge the same cherry-pick in all branches at the same time. That is why I created these PRs

@rata
Copy link
Member Author

rata commented Dec 23, 2021

/retest

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 28, 2021
@rata
Copy link
Member Author

rata commented Dec 29, 2021

@liggitt This is still missing the lgtm label, but you have provided both in this PR for other branches, so maybe you can do the same for this? :)

/assign @liggitt

@jkh52
Copy link
Contributor

jkh52 commented Dec 29, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2021
@liggitt
Copy link
Member

liggitt commented Jan 4, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit f3ca839 into kubernetes:release-1.21 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

@jkh52 jkh52

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rata @k8s-ci-robot @jkh52 @leilajal @liggitt @justaugustus