Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing maximum number of ports allowed in EndpointSlice #99795

Merged
merged 1 commit into from Mar 4, 2021
Merged

Increasing maximum number of ports allowed in EndpointSlice #99795

merged 1 commit into from Mar 4, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Mar 4, 2021 •
edited by liggitt

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Increases maximum number of ports allowed in EndpointSlices from 100 to 20,000.

Which issue(s) this PR fixes:

Helps with #99382

Does this PR introduce a user-facing change?

Fixes a regression in 1.18+ where endpoint slice controller would attempt to create endpoint slices with too many ports; the maximum number of ports allowed in EndpointSlices has been increased from 100 to 20,000

/sig network
/priority important-soon
/triage accepted
/cc @freehan
/assign @thockin

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 4, 2021
robscott
robscott commented Mar 4, 2021
View reviewed changes
pkg/apis/discovery/validation/validation.go Outdated
@@ -40,7 +40,7 @@ var (
)
maxTopologyLabels = 16
maxAddresses = 100
maxPorts = 100
maxPorts = 16000
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the small diff, there is test coverage for this, it just uses this variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/discovery/validation/validation_test.go#L269 and https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/discovery/validation/validation_test.go#L168

@robscott robscott mentioned this pull request Mar 4, 2021
Closed
@thockin
Copy link
Member

thockin commented Mar 4, 2021 via email

@robscott robscott force-pushed the endpointslice-ports-validation branch from e420955 to 8bd6b5d Compare March 4, 2021 18:04
@robscott
Copy link
Member Author

robscott commented Mar 4, 2021

@thockin makes sense, updated to 20k.

@thockin
Copy link
Member

thockin commented Mar 4, 2021

Is there a followup bug filed to fix the slice controllers to consider ports?

@thockin
Copy link
Member

thockin commented Mar 4, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@robscott
Copy link
Member Author

robscott commented Mar 4, 2021

Is there a followup bug filed to fix the slice controllers to consider ports?

@thockin I removed the fixes keyword from this PR and will leave the original issue open since I think it's still applicable, just with a higher number. I'll add some more detail there as far as what additional steps we could take.

@k8s-ci-robot k8s-ci-robot merged commit d11582b into kubernetes:master Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 4, 2021
@aojea aojea mentioned this pull request Mar 4, 2021
Merged
@tengqm
Copy link
Contributor

tengqm commented Mar 5, 2021

Pls check if this change should be mentioned in the content/en/docs/concepts/services-networking/endpoint-slices.md on k8s/website.

This was referenced Mar 18, 2021
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 23, 2021
@k8s-ci-robot
Merge pull request #100497 from robscott/automated-cherry-pick-of-#99…
91ad058 
…795-release-1.18

Automated cherry pick of #99795: Increasing maximum number of ports allowed in EndpointSlice
k8s-ci-robot added a commit that referenced this pull request Mar 23, 2021
@k8s-ci-robot
Merge pull request #100380 from robscott/automated-cherry-pick-of-#99…
5c928ab 
…795-release-1.20

Automated cherry pick of #99795: Increasing maximum number of ports allowed in EndpointSlice
k8s-ci-robot added a commit that referenced this pull request Mar 23, 2021
@k8s-ci-robot
Merge pull request #100381 from robscott/automated-cherry-pick-of-#99…
bfef9b0 
…795-release-1.19

Automated cherry pick of #99795: Increasing maximum number of ports allowed in EndpointSlice
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan Awaiting requested review from freehan

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @thockin @k8s-ci-robot @tengqm @liggitt