Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cmd/proxy/{config, healthcheck, winkernel} to structured logging #104944

Merged
merged 3 commits into from Sep 20, 2021
Merged

Migrate cmd/proxy/{config, healthcheck, winkernel} to structured logging #104944

merged 3 commits into from Sep 20, 2021

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Sep 13, 2021 •
edited

Signed-off-by: jyz0309 45495947@qq.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

related to #104872

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate `cmd/proxy/{config, healthcheck, winkernel}` to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

@jyz0309: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 13, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 13, 2021

/wg structured-logging
/area logging
/priority important-longterm
/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2021
@shiva1333 shiva1333 mentioned this pull request Sep 13, 2021
Closed
@serathius
Copy link
Contributor

Please don't write Fixes X as this will close the original Issue

@serathius serathius moved this from Inbox to Waiting on Reviewer in WG Structured Logging - 1.23 Migration Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2021
yangjunmyfm192085
yangjunmyfm192085 reviewed Sep 14, 2021
View reviewed changes
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2021
@yangjunmyfm192085
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2021
@mengjiao-liu
Copy link
Member

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 16, 2021

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

I will squash all commits into 1 commit to solve it.

@jyz0309
migrate to struct log for proxy
615c696 
Signed-off-by: jyz0309 <45495947@qq.com>

remove useless str

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 16, 2021

The content of the code is fine, except:
I think the commits should clearly say what was updated rather than fix comment.

All commits left on your branch after a review should represent meaningful milestones or units of work. Use commits to add clarity to the development and review process.

see Kubernetes contributors guide for more details.

done. Please take a look again~

@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 16, 2021

/retest-required

@serathius
Copy link
Contributor

/cc @thockin

@serathius serathius moved this from Waiting on Reviewer to Needs Approval in WG Structured Logging - 1.23 Migration Sep 17, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 20, 2021

/assign @thockin

thockin
thockin reviewed Sep 20, 2021
View reviewed changes
pkg/proxy/config/config.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/healthcheck/service_health.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
pkg/proxy/winkernel/hnsV1.go Outdated Show resolved Hide resolved
@jyz0309
rebuild msg and rename namespace
6344d6b 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
fix type check
5d32be4 
Signed-off-by: jyz0309 <45495947@qq.com>
thockin
thockin reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit acbeaf8 into kubernetes:master Sep 20, 2021
WG Structured Logging - 1.23 Migration automation moved this from Needs Approval to Done Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@freehan freehan Awaiting requested review from freehan

@yuzhiquan yuzhiquan Awaiting requested review from yuzhiquan

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
WG Structured Logging - 1.23 Migration
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jyz0309 @k8s-ci-robot @serathius @yangjunmyfm192085 @mengjiao-liu @k8s-triage-robot @yuzhiquan @thockin