New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #106906: mount-utils: Detect potential stale file handle #106988
Automated cherry pick of #106906: mount-utils: Detect potential stale file handle #106988
Conversation
This is a fix for the issue kubernetes#97031. It may happen that a subpath mount point on a networking FS gets deleted on the server but in the case of some file systems (CIFS) it would make the stat syscall end with ENOENT, preventing the mount point to be cleaned up and pods using the mount can't be cleanly deleted. This situation can be detected by calling also access syscall on the same path: if there is a discrepancy between stat and access results, treating the mount as corrupted allows for successful cleanup and unmount.
@andyzhangx: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review. (For details on the patch release process and schedule, see the Patch Releases page.) Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/retest |
1 similar comment
/retest |
/lgtm |
Do we also need to cherry-pick this to other release branches or only 1.23 is affected? |
Hey @andyzhangx thanks for submitting the CPs for the other branches! We were checking the progress of this cherry-pick but we are forced to wait for the next patch set because we need to merge them all together to keep the branches even. Let's get the missing approvals and tests ready in #107039 #107040 for the next round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note-none
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #106906 on release-1.23.
#106906: mount-utils: Detect potential stale file handle
For details on the cherry pick process, see the cherry pick requests page.
Does this PR introduce a user-facing change?