Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause Images: Added base image for Windows Server 2022 #104438

Merged
merged 2 commits into from Aug 25, 2021
Merged

Pause Images: Added base image for Windows Server 2022 #104438

merged 2 commits into from Aug 25, 2021

Conversation

nick5616
Copy link
Contributor

What type of PR is this?

Enable new OS

/sig windows
/kind feature

What this PR does / why we need it:

Windows Server 2022 has become available. This PR adds Windows Server 2022 as a supported pause image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The pause image list now contains Windows Server 2022

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @nick5616!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nick5616. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2021
@jsturtevant
Copy link
Contributor

/sig windows
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 18, 2021
@jsturtevant
Copy link
Contributor

/check-cla

@jsturtevant
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2021
@jsturtevant
Copy link
Contributor

/cc @claudiubelu

@nick5616
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2021
@nick5616
Copy link
Contributor Author

Successful build output
https://gist.github.com/nick5616/eaa7c8b40a9623884c55374518b5bf38

DockerHub
https://hub.docker.com/r/nick5616/pause/tags?page=1&ordering=last_updated

@nick5616
Copy link
Contributor Author

/retest

@claudiubelu
Copy link
Contributor

Hello, thanks for the contribution!

The commit looks good, I don't think we need any other changes. the image pause:3.6 has not been promoted from staging yet [1], so we don't have to bump the version either. I have also been able to build the image locally.

After this PR merges, a PR should be opened here [1] and add the new pause image SHA, so it will be officially published.

/lgtm

[1] https://github.com/kubernetes/k8s.io/blob/c8b744d34f4f017ff6989557a2acc37ed2d3f1be/k8s.gcr.io/images/k8s-staging-kubernetes/images.yaml#L4497

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@jsturtevant
Copy link
Contributor

/assign @BenTheElder @dims

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, nick5616

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2a8ad72 into kubernetes:master Aug 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 25, 2021
@marosset marosset added this to Done (v1.23) in SIG-Windows Oct 7, 2021
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Feb 2, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
b0a36c5 
This commit replaces Windows Server 2004, which has fallen out of support,
with the newly supported Windows Server 2022
(kubernetes/kubernetes#104438).
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Feb 2, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
d4d2e08 
This commit replaces Windows Server 2004, which has fallen out of support,
with the newly supported Windows Server 2022
(kubernetes/kubernetes#104438).
@saifshaikh48 saifshaikh48 mentioned this pull request Feb 2, 2022
Merged
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Feb 3, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
02c6a0e 
This commit replaces Windows Server 2004, which has fallen out of support,
with the newly supported Windows Server 2022
(kubernetes/kubernetes#104438).
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Mar 8, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
2082c03 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Mar 9, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
3a63398 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/windows-machine-config-operator-1 that referenced this pull request Mar 10, 2022
@saifshaikh48
Support Windows Server 2022 in vSphere CI
cbd9444 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/windows-machine-config-operator-1 that referenced this pull request Mar 10, 2022
@saifshaikh48
Support Windows Server 2022 in vSphere CI
f9870b3 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
efe8e7b 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
It points vSphere CI to use the new WS2022 golden image with Docker
pre-installed and the OS-level container networking patch released by Microsoft:
https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

Squash of cherry picked commits:
3a63398, 4895766
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
250909a 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

(cherry picked from commit 3a63398)
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
62e59b1 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

(cherry picked from commit 3a63398)
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
d62d564 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
The golden image referenced is baked with a private networking OS hotfix
given by Microsoft for internal testing only.

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

(cherry picked from commit 3a63398)
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
7f71fa9 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
It points vSphere CI to use the new WS2022 golden image with Docker
pre-installed and the OS-level container networking patch released by Microsoft:
https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

Squash of cherry picked commits:
3a63398, 4895766
saifshaikh48 added a commit to saifshaikh48/windows-machine-config-operator that referenced this pull request Jul 7, 2022
@saifshaikh48
[e2e] Support Windows Server 2022 in vSphere CI
e01d3b9 
This commit replaces Windows Server 2004, which has fallen out of support,
with Windows Server 2022 (kubernetes/kubernetes#104438).
It points vSphere CI to use the new WS2022 golden image with Docker
pre-installed and the OS-level container networking patch released by Microsoft:
https://support.microsoft.com/en-us/topic/april-25-2022-kb5012637-os-build-20348-681-preview-2233d69c-d4a5-4be9-8c24-04a450861a8d

This commit houses a temporary split between the vSphere and platform=none jobs.
Since the release repo points platform=none to use the 2004 golden image,
in order for this PR to merge we need to pull compatible container images
depending on the platform.

Squash of cherry picked commits:
3a63398, 4895766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan Awaiting requested review from hasheddan

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

Assignees

@dims dims

@justaugustus justaugustus

@BenTheElder BenTheElder

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG-Windows
  
Done (v1.23)
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nick5616 @k8s-ci-robot @jsturtevant @claudiubelu @justaugustus @dims @BenTheElder