kubeadm: get k8s CI version markers from k8s infra bucket #98836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates kubeadm version resolution to use kubernetes community infra bucket to fetch appropriate k8s ci versions. The images are already being pulled from the kubernetes community infra bucket meaning that a mismatch can occur when the ci version is fetched from the google infra bucket and the image is not yet present on k8s infra. Follow-up to kubernetes#97087 Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
The k8s release bucket constant is not longer overriden in network tests because the fetcher is mocked rather than using httptest.NewServer. See previous implementation in https://github.com/kubernetes/kubernetes/pull/49119/files#diff-82f2b09991047d4a1884d53dedadd64a473d5c4dc75293514e71773ceedf08e2R128 Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/release
neolit123
reviewed
Feb 6, 2021
There was a problem hiding this comment.
SGTM, if we are applying this it also must be backported in the support skew.
@hasheddan are you willing to send the cherry picks?
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
@neolit123 absolutely :) |
|
/retest |
|
IIRC a release note must be added here, which will make it not required on the cherry picks.
|
k8s-ci-robot
added
release-note
|
/retest |
|
Thanks Dan! |
k8s-ci-robot
added
the
area/release-eng
This was referenced Feb 6, 2021
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 8, 2021
…836-upstream-release-1.19 Automated cherry pick of #98836: kubeadm: get k8s CI version markers from k8s infra bucket
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 8, 2021
…836-upstream-release-1.20 Automated cherry pick of #98836: kubeadm: get k8s CI version markers from k8s infra bucket
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 8, 2021
…836-upstream-release-1.18 Automated cherry pick of #98836: kubeadm: get k8s CI version markers from k8s infra bucket
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Updates kubeadm version resolution to use kubernetes community infra
bucket to fetch appropriate k8s ci versions. The images are already
being pulled from the kubernetes community infra bucket meaning that a
mismatch can occur when the ci version is fetched from the google infra
bucket and the image is not yet present on k8s infra.
Follow-up to #97087
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Which issue(s) this PR fixes:
xref #98646
Special notes for your reviewer:
This should likely be CP'ed back to 1.20 branch as well.
Context: https://kubernetes.slack.com/archives/C09QZ4DQB/p1612269558032700
/priority critical-urgent
/sig release
/assign @neolit123
/cc @justaugustus @saschagrunert
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: