Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pause image to 3.4.1 and also update the change log #98205

Merged
merged 5 commits into from Feb 9, 2021
Merged

update pause image to 3.4.1 and also update the change log #98205

merged 5 commits into from Feb 9, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 20, 2021 •
edited

What type of PR is this?
/kind documentation
/sig windows
/kind feature

What this PR does / why we need it:
When I build images in my env and it tries to get 3.4.1 which was not built yesterday.
And

Next Step for CRI Runtimes: CRI downstream changes as only docker-shim's pause image can be configured in kubelet #55676 (comment). BTW, dockershim deprecation and plan to deprecate kubelet flag -pod-infra-container-image:

Documentation Change

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

pause image upgraded to 3.4.1 in kubelet and kubeadm for both Linux and Windows.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm area/kubectl area/kubelet labels Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 20, 2021
@pacoxu pacoxu force-pushed the build/pauses branch 5 times, most recently from 3cc265d to fbcf030 Compare January 20, 2021 08:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2021
@pacoxu pacoxu force-pushed the build/pauses branch 2 times, most recently from 86886e8 to d966e0b Compare January 20, 2021 09:33
ehashman
ehashman reviewed Jan 20, 2021
View reviewed changes
build/dependencies.yaml Outdated Show resolved Hide resolved
@pacoxu pacoxu force-pushed the build/pauses branch 2 times, most recently from f16dbf3 to f84c47b Compare January 21, 2021 03:12
@pacoxu
Copy link
Member Author

pacoxu commented Feb 7, 2021 •
edited

@BenTheElder So should we wait for kind and containerd changes to merge?

@BenTheElder
Copy link
Member

BenTheElder commented Feb 7, 2021 •
edited

@BenTheElder So should we wait for kind and containerd changes to merge?

I'm not actually sure how we want to approach this.
I think it's new that presubmit doesn't run this from the locations you updated it, based on dockershim going on the way out.
I don't think we have a great plan for qualifying pause currently, it usually just works fiiiine, but it feels bad to not actually have tests anywhere.

@pacoxu pacoxu mentioned this pull request Feb 7, 2021
Merged
@dims
Copy link
Member

dims commented Feb 7, 2021

https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-master is still testing docker,

[dims@dims-a01 22:22] ~/Downloads ⟩ rg 'container-runtime="docker"'
tmp-node-e2e-f61ec3da-ubuntu-gke-1804-1-16-v20200330/kubelet.log
37:Feb 07 01:28:35 tmp-node-e2e-f61ec3da-ubuntu-gke-1804-1-16-v20200330 kubelet[3752]: I0207 01:28:35.342940    3752 flags.go:59] FLAG: --container-runtime="docker"

tmp-node-e2e-f61ec3da-cos-81-12871-1245-6/kubelet.log
38:Feb 07 01:28:33 tmp-node-e2e-f61ec3da-cos-81-12871-1245-6 kubelet[1861]: I0207 01:28:33.020269    1861 flags.go:59] FLAG: --container-runtime="docker"

tmp-node-e2e-f61ec3da-cos-85-13310-1209-7/kubelet.log
38:Feb 07 01:28:33 tmp-node-e2e-f61ec3da-cos-85-13310-1209-7 kubelet[1975]: I0207 01:28:33.349476    1975 flags.go:59] FLAG: --container-runtime="docker"

@pacoxu pacoxu mentioned this pull request Feb 8, 2021
Merged
2 tasks
@pacoxu
Copy link
Member Author

pacoxu commented Feb 8, 2021 •
edited

Are there any projects that I missed? @dims and @BenTheElder

As #98765 mentioned that dockershim is deprecating and we may have a plan to deprecate the --pod-infra-container-image in kubelet, we can add some checking in kubelet to check/warning pause image configurations from container info. If cri is using an old pause image, just add a message for warning/information.

@pacoxu pacoxu mentioned this pull request Feb 8, 2021
Merged
@TBBle
Copy link

TBBle commented Feb 8, 2021 •
edited

Are there any projects that I missed?

minikube has a few references to k8s.gcr.io/pause:3.2, specifically overriding containerd and cri-o configs, similarly to kind, which you already have a PR for. Weirdly enough, their nvidia-driver-installer addon seems to mandate k8s.gcr.io/pause:2.0.

soltysh
soltysh approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

spiffxp
spiffxp approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@BenTheElder
Copy link
Member

/approve

however: I still think we should write up something about the intended approach to managing this image, so we don't have to determine if it's appropriate on each PR. I'm iffy on the current approach of "upgrade then test" ...

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato, dims, ehashman, mrunalp, neolit123, pacoxu, soltysh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member Author

pacoxu commented Feb 8, 2021

/test pull-kubernetes-e2e-kind-ipv6

@pacoxu
Copy link
Member Author

pacoxu commented Feb 9, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2b7c61b into kubernetes:master Feb 9, 2021
SIG Node CI/Test Board automation moved this from PRs - Reviewer lgtm'd to Done Feb 9, 2021
@pacoxu pacoxu mentioned this pull request Feb 9, 2021
Closed
This was referenced Feb 9, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 1, 2021
Closed
Merged
@saschagrunert saschagrunert mentioned this pull request Mar 16, 2021
Merged
This was referenced May 3, 2021
Closed
Closed
Closed
@pacoxu pacoxu deleted the build/pauses branch June 23, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@spiffxp spiffxp spiffxp approved these changes

@soltysh soltysh soltysh approved these changes

@cpanato cpanato cpanato approved these changes

@ehashman ehashman ehashman approved these changes

@dims dims Awaiting requested review from dims

Assignees

@mrunalp mrunalp

@smarterclayton smarterclayton

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet