kube-controller-manager: properly check generic ephemeral volume feature #104913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19, support for generic ephemeral inline volumes in the PVC protection controller was incorrectly tied to the "storage object in use" feature gate.
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/api-machinery
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cc @deads2k to take a look |
k8s-ci-robot
added
the
triage/accepted
|
@fedebongio: GitHub didn't allow me to request PR reviews from the following users: to, take, a, look. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
needs-triage
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Sep 15, 2021
Merged
Merged
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 6, 2021
…3-origin-release-1.20 Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 6, 2021
…3-origin-release-1.21 Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 14, 2021
…3-origin-release-1.22 Automated cherry pick of #104913: kube-controller-manager: properly check generic ephemeral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19,
support for generic ephemeral inline volumes in the PVC protection controller
was incorrectly tied to the "storage object in use" feature gate.
Special notes for your reviewer:
Found by @ikeeip when removing the StorageObjectInUseProtection feature gate (#104903 (comment)).
Does this PR introduce a user-facing change?