Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging #104928

Merged
merged 10 commits into from Sep 15, 2021
Merged

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging #104928

merged 10 commits into from Sep 15, 2021

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Sep 11, 2021 •
edited

Signed-off-by: jyz0309 45495947@qq.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging

Which issue(s) this PR fixes:

relate to #104872

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jyz0309
migrate log
e2df90d 
Signed-off-by: jyz0309 <45495947@qq.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 11, 2021
@k8s-ci-robot
Copy link
Contributor

@jyz0309: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @jyz0309. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 11, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 11, 2021

/wg structured-logging
/area logging
/priority important-longterm
/cc @kubernetes/wg-structured-logging-reviews

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 11, 2021
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 11, 2021
thockin
thockin reviewed Sep 11, 2021
View reviewed changes
cmd/kube-proxy/app/server_others.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
pkg/proxy/metaproxier/meta_proxier.go Outdated Show resolved Hide resolved
@shiva1333 shiva1333 mentioned this pull request Sep 11, 2021
Closed
thockin
thockin reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2021
@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 14, 2021

Please resolve conflict

done. PTAL

@jyz0309
fix comment
ab8915c 
Signed-off-by: jyz0309 <45495947@qq.com>
@yangjunmyfm192085
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2021
@jyz0309
Copy link
Contributor Author

jyz0309 commented Sep 14, 2021

/retest-required

@jyz0309
fix comment
0730eaa 
Signed-off-by: jyz0309 <45495947@qq.com>
@yangjunmyfm192085
Copy link
Contributor

/retest

@ehashman ehashman added this to Triage in SIG Node PR Triage Sep 14, 2021
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 14, 2021
@jyz0309
fix comment
3aabbff 
Signed-off-by: jyz0309 <45495947@qq.com>
thockin
thockin reviewed Sep 15, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyz0309, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5449ce7 into kubernetes:master Sep 15, 2021
SIG Node PR Triage automation moved this from Triage to Done Sep 15, 2021
WG Structured Logging - 1.23 Migration automation moved this from Waiting on Reviewer to Done Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 15, 2021
@ccampo133 ccampo133 mentioned this pull request Sep 16, 2021
Closed
ibabou pushed a commit to ibabou/kubernetes that referenced this pull request Sep 28, 2021
@jyz0309 @ibabou
Migrate cmd/proxy/app and pkg/proxy/meta_proxier to structured lo…
2500231 
…gging (kubernetes#104928)

* migrate log

Signed-off-by: jyz0309 <45495947@qq.com>

* remove useless change

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

* use nil to instead err

Signed-off-by: jyz0309 <45495947@qq.com>

* fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

* remove useless change

Signed-off-by: jyz0309 <45495947@qq.com>

* resolve conflict

Signed-off-by: jyz0309 <45495947@qq.com>

* resolve conflict

Signed-off-by: jyz0309 <45495947@qq.com>

* fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

* fix comment

Signed-off-by: jyz0309 <45495947@qq.com>

* fix comment

Signed-off-by: jyz0309 <45495947@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchan pchan pchan left review comments

@thockin thockin thockin left review comments

@freehan freehan Awaiting requested review from freehan

@yangjunmyfm192085 yangjunmyfm192085 Awaiting requested review from yangjunmyfm192085

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/logging area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Node PR Triage
Done
WG Structured Logging - 1.23 Migration
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jyz0309 @k8s-ci-robot @robscott @serathius @yangjunmyfm192085 @fedebongio @k8s-triage-robot @pchan @thockin