Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference in disruption controller #98750

Merged
merged 1 commit into from Feb 4, 2021
Merged

Fix nil pointer dereference in disruption controller #98750

merged 1 commit into from Feb 4, 2021

Conversation

mortent
Copy link
Member

@mortent mortent commented Feb 4, 2021 •
edited by liggitt

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes problem where invalid selector on PDBs leads to a nil pointer dereference that causes the controller-manager to crash-loop.

Which issue(s) this PR fixes:
Fixes #98702

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes a panic in the disruption budget controller for PDB objects with invalid selectors

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig apps
@kubernetes/sig-apps-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

@mortent: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 4, 2021
@janetkuo
Copy link
Member

janetkuo commented Feb 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@mortent
Copy link
Member Author

mortent commented Feb 4, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 9273c3b into kubernetes:master Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
@liggitt
Copy link
Member

liggitt commented Feb 4, 2021

thanks, can this be picked to release branches (1.18-1.20)?

This was referenced Feb 4, 2021
Merged
Merged
Merged
@ialidzhikov
Copy link
Contributor

thanks, can this be picked to release branches (1.18-1.20)?

release-1.20 - #98775
release-1.19 - #98776
release-1.18 - #98777

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 5, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2021
@k8s-ci-robot
Merge pull request #98777 from ialidzhikov/automated-cherry-pick-of-#…
edd8bd0 
…98750-upstream-release-1.18

Automated cherry pick of #98750: Fix nil pointer dereference in disruption controller
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2021
@k8s-ci-robot
Merge pull request #98776 from ialidzhikov/automated-cherry-pick-of-#…
4794d40 
…98750-upstream-release-1.19

Automated cherry pick of #98750: Fix nil pointer dereference in disruption controller
k8s-ci-robot added a commit that referenced this pull request Feb 9, 2021
@k8s-ci-robot
Merge pull request #98775 from ialidzhikov/automated-cherry-pick-of-#…
217a1c4 
…98750-upstream-release-1.20

Automated cherry pick of #98750: Fix nil pointer dereference in disruption controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

DisruptionController nil pointer dereference
5 participants
@mortent @k8s-ci-robot @janetkuo @liggitt @ialidzhikov