Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pause image references to use 3.6 #104711

Merged
merged 1 commit into from Sep 14, 2021
Merged

update pause image references to use 3.6 #104711

merged 1 commit into from Sep 14, 2021

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Sep 1, 2021 •
edited

What type of PR is this?

/kind cleanup
/sig release
/priority important-soon

What this PR does / why we need it:

The pause:3.6 image has been published.

Also updates older / incorrect references.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support for Windows Server 2022 was added to the k8s.gcr.io/pause:3.6 image.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@claudiubelu
updates pause image references
18936d4 
The pause:3.6 image has been published.

Also updates older / incorrect references.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 1, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Sep 1, 2021
@SergeyKanzhelev
Copy link
Member

/cc

neolit123
neolit123 reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for kubeadm / test

Does this PR introduce a user-facing change?

we have to be clearer in terms of what updates are included in this pause image bump.
we should include a short summary / changelog for pause 3.6 in the release note field.

/retitle update pause image references to use 3.6
/triage accepted

@k8s-ci-robot k8s-ci-robot changed the title updates pause image references update pause image references to use 3.6 Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2021
@endocrimes
Copy link
Member

@claudiubelu kubelet serial tests are known-flaky. Looks like no new or unexpected failures happened during the last run.

@endocrimes endocrimes moved this from Triage to Needs Approver in SIG Node PR Triage Sep 7, 2021
@endocrimes
Copy link
Member

/lgtm
(kubelet changes and node-kubelet-serial state)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@claudiubelu
Copy link
Contributor Author

/assign @BenTheElder @pwittrock @yujuhong

@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-node-kubelet-serial

@endocrimes
Copy link
Member

@claudiubelu https://testgrid.k8s.io/sig-node-presubmits#pr-node-kubelet-serial - there hasn't been a clean run of that suite in as long as test grid has history - no need to keep re-testing.

@kerthcet kerthcet mentioned this pull request Sep 10, 2021
Closed
15 tasks
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 13, 2021
@dims
Copy link
Member

dims commented Sep 13, 2021

/approve
/lgtm
/retest

@dims
Copy link
Member

dims commented Sep 13, 2021

/assign @eddiezane

(for sig-cli approval)

@eddiezane
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, dims, eddiezane, mrunalp, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

@claudiubelu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial 18936d4 link false /test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit c79f7c1 into kubernetes:master Sep 14, 2021
@wgahnagl wgahnagl mentioned this pull request Sep 14, 2021
Merged
kl52752 pushed a commit to kl52752/kubernetes that referenced this pull request Dec 23, 2022
@kl52752
Backport pause:3.6 to gke/cluster directory
f40a748 
Apply cluster/* changes from 18936d4
kubernetes#104711

BUG=199792129

Change-Id: I9aafa1a5e2b2cef59d90acf313f3ad0b40387e97
aojea pushed a commit to aojea/kubernetes that referenced this pull request Jun 14, 2023
@aojea
Backport pause:3.6 to gke/cluster directory
25741f3 
Apply cluster/* changes from 18936d4
kubernetes#104711

BUG=199792129

Change-Id: I9aafa1a5e2b2cef59d90acf313f3ad0b40387e97
serathius pushed a commit to serathius/kubernetes that referenced this pull request Mar 14, 2024
Backport pause:3.6 to gke/cluster directory
f73eb03 
Apply cluster/* changes from 18936d4
kubernetes#104711

BUG=199792129

Change-Id: I9aafa1a5e2b2cef59d90acf313f3ad0b40387e97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@mrunalp mrunalp mrunalp approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@brianpursley brianpursley Awaiting requested review from brianpursley

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@BenTheElder BenTheElder

@eddiezane eddiezane

@endocrimes endocrimes

@pwittrock pwittrock

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet