Enforce metric cardinality check to Gauge, Histogram and Summary metric #99738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/api-machinery
|
/assign @logicalhan PHAL:) |
8 tasks
logicalhan
approved these changes
Mar 4, 2021
| @@ -156,6 +166,9 @@ func (v *HistogramVec) With(labels map[string]string) ObserverMetric { | |||
| if !v.IsCreated() { | |||
| return noop | |||
| } | |||
| if v.LabelValueAllowLists != nil { | |||
There was a problem hiding this comment.
nit: it might be cleaner to set this to an no-opt struct and always just call v.LabelValueAllowLists.ConstrainLabelMap(labels)
| @@ -99,12 +99,19 @@ type SummaryVec struct { | |||
| func NewSummaryVec(opts *SummaryOpts, labels []string) *SummaryVec { | |||
| opts.StabilityLevel.setDefaults() | |||
|
|
|||
| fqName := BuildFQName(opts.Namespace, opts.Subsystem, opts.Name) | |||
There was a problem hiding this comment.
maybe we should have a method on opts which is opts.FQName()? (not in this PR though).
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan, YoyinZyc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/triage accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Following up #99385, this PR enforce metric cardinality check to other types(Gauge, Histogram, Summary) metric.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: