Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync node status during kubelet node shutdown #98005

Merged
merged 1 commit into from Jan 29, 2021
Merged

Sync node status during kubelet node shutdown #98005

merged 1 commit into from Jan 29, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jan 13, 2021 •
edited

Fix rescheduled to the node of shutdown state

What type of PR is this?
/kind bug
/sig node

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #98004

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Sync node status during kubelet node shutdown.
Adds an pod admission handler that rejects new pods when the node is in progress of shutting down.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wzshiming. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 13, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Jan 14, 2021
@wzshiming
Copy link
Member Author

@mrunalp @Random-Liu @derekwaynecarr PTAL

@wzshiming
Copy link
Member Author

/assign @derekwaynecarr

@lala123912
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2021
ehashman
ehashman reviewed Jan 19, 2021
View reviewed changes
pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go
@@ -31,6 +31,7 @@ import (
"k8s.io/klog/v2"
"k8s.io/kubernetes/pkg/features"
"k8s.io/kubernetes/pkg/kubelet/eviction"
"k8s.io/kubernetes/pkg/kubelet/lifecycle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dependencies changed, you need to run the update-bazel.sh script. This is why the tests are failing.

@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Jan 19, 2021
@wzshiming wzshiming force-pushed the fix-rescheduling-to-the-shutdown-node branch 3 times, most recently from 3d48ec2 to da9f867 Compare January 19, 2021 02:50
@bobbypage
Copy link
Member

/assign

@wzshiming
Copy link
Member Author

@bobbypage Done.

@wzshiming wzshiming force-pushed the fix-rescheduling-to-the-shutdown-node branch from 9015bb9 to ef719a0 Compare January 21, 2021 02:19
@bobbypage
Copy link
Member

thanks!

/lgtm
/assign @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@wzshiming wzshiming force-pushed the fix-rescheduling-to-the-shutdown-node branch from ef719a0 to d9df265 Compare January 21, 2021 03:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@wzshiming wzshiming mentioned this pull request Jan 25, 2021
Closed
6 tasks
@ehashman
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 25, 2021
@mrunalp
Copy link
Contributor

mrunalp commented Jan 29, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9ec1e23 into kubernetes:master Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@wzshiming wzshiming deleted the fix-rescheduling-to-the-shutdown-node branch January 31, 2021 12:48
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
@wzshiming wzshiming mentioned this pull request Feb 3, 2021
Merged
@wzshiming wzshiming mentioned this pull request Feb 20, 2021
Merged
jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 2, 2021
@wzshiming
kubelet: Sync node status during kubelet node shutdown
fd59ec1 
Cherrypicking kubernetes#98005 from upstream

kubernetes#98005

Change-Id: If48a683d0c236377694d90e380fe0a73e1e692bc
k8s-ci-robot added a commit that referenced this pull request Mar 12, 2021
@k8s-ci-robot
Merge pull request #99254 from wzshiming/automated-cherry-pick-of-#98…
c1ee348 
…005-upstream-release-1.20

Automated cherry pick of #98005: Sync node status during kubelet node shutdown
This was referenced Mar 12, 2021
Closed
Merged
@kwilczynski kwilczynski mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage bobbypage left review comments

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

GracefulNodeShutdown rescheduled to the node of shutdown state
7 participants
@wzshiming @k8s-ci-robot @lala123912 @bobbypage @ehashman @mrunalp @derekwaynecarr