Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch cronjob controller to batch/v1 #99423

Merged
merged 9 commits into from Mar 5, 2021
Merged

Switch cronjob controller to batch/v1 #99423

merged 9 commits into from Mar 5, 2021

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 24, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This promotes CronJob controller to use batch/v1 based on kubernetes/enhancements#19 and complete description from https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

Special notes for your reviewer:

This builds on top of #98965 so only the last commit matters.

/assign @deads2k @liggitt

Does this PR introduce a user-facing change?

Promote CronJobs to batch/v1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 24, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Feb 24, 2021

/triage accepted
/sig apps
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/apps Categorizes an issue or PR as relevant to SIG Apps. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 24, 2021
@soltysh soltysh mentioned this pull request Feb 24, 2021
Closed
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2021

/test pull-kubernetes-conformance-kind-ipv6-parallel

@soltysh soltysh changed the title Cronjob controller Switch cronjob controller to batch/v1 Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-unit

2 similar comments
@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-unit

@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-unit

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@liggitt
Copy link
Member

liggitt commented Mar 5, 2021

/lgtm
/approve

Split #99197 into two PRs:

  • one that switches the e2e to use v1
  • one that promotes the test to conformance

Once this merges, we'll merge the "switch e2e to v1" PR and let the "promote to conformance" PR soak for two weeks before merging

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@liggitt liggitt mentioned this pull request Mar 5, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

@soltysh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind 78f51f8 link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Mar 5, 2021

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit 06a4b6f into kubernetes:master Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 5, 2021
@soltysh soltysh deleted the cronjob_controller branch March 5, 2021 18:07
@annajung annajung mentioned this pull request Mar 10, 2021
Closed
16 tasks
@reylejano reylejano mentioned this pull request Apr 6, 2021
Merged
@wangyysde wangyysde mentioned this pull request May 19, 2021
Merged
This was referenced May 26, 2021
Merged
Merged
@wangyysde wangyysde mentioned this pull request Jun 1, 2021
Closed
@mengjiao-liu mengjiao-liu mentioned this pull request Jun 2, 2021
Closed
@ChenglongGao327 ChenglongGao327 mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaypatel07 alaypatel07 alaypatel07 approved these changes

@apelisse apelisse Awaiting requested review from apelisse

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

Assignees

@liggitt liggitt

@ingvagabund ingvagabund

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test area/workload-api/cronjob cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@soltysh @fejta-bot @k8s-ci-robot @liggitt @ingvagabund @alaypatel07 @deads2k