New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual cherry pick of #104817: kubelet: Rejected pods should be filtered from admission #104918
Manual cherry pick of #104817: kubelet: Rejected pods should be filtered from admission #104918
Conversation
@ehashman: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review. (For details on the patch release process and schedule, see the Patch Releases page.) Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
/lgtm |
A pod that has been rejected by admission will have status manager set the phase to Failed locally, which make take some time to propagate to the apiserver. The rejected pod will be included in admission until the apiserver propagates the change back, which was an unintended regression when checking pod worker state as authoritative. A pod that is terminal in the API may still be consuming resources on the system, so it should still be included in admission. [ehashman] Rebased on top of kubernetes#104847.
9dab9cb
to
8d456f2
Compare
|
/triage accepted |
/easycla |
/approve |
/lgtm |
/skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, saschagrunert, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Other folks seem to have the same CLA issues, so I’ll not block on that: kubernetes/org#3068 |
Cherry pick of #104817 on release-1.22.
#104817: kubelet: Rejected pods should be filtered from admission
Edit: I had to manually rebase this on top of #104847 whose backport merged before this.
For details on the cherry pick process, see the cherry pick requests page.