Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #104743: Ensure there is one running static pod with the same full name #106394

Merged
merged 2 commits into from Dec 2, 2021
Merged

Automated cherry pick of #104743: Ensure there is one running static pod with the same full name #106394

merged 2 commits into from Dec 2, 2021

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Nov 12, 2021 •
edited

Cherry pick of #104743 on release-1.22.

#104743: Ensure there is one running static pod with the same full name

For details on the cherry pick process, see the cherry pick requests page.

Respect grace period when updating static pods.

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Nov 12, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2021
@gjkim42 gjkim42 changed the title Automated cherry pick of #104743: NodeConformance: Respect grace period when updating Automated cherry pick of #104743: Ensure there is one running static pod with the same full name Nov 12, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Nov 12, 2021

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Nov 13, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Nov 15, 2021

/assign @smarterclayton
/cc @ehashman

ehashman
ehashman reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/lgtm

Affects 1.22 only, not applicable to prior releases.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Nov 16, 2021

/assign @hasheddan
For cherry-pick approval :)

@gjkim42
Copy link
Member Author

gjkim42 commented Nov 17, 2021

/unassign @hasheddan

@kubernetes/release-managers

for cherry-pick approval

@ehashman ehashman moved this from Needs Approver to Done in SIG Node PR Triage Nov 29, 2021
@puerco
Copy link
Member

puerco commented Dec 2, 2021

Thank you @gjkim42
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 2, 2021
@puerco
Copy link
Member

puerco commented Dec 2, 2021

/test pull-kubernetes-e2e-kind

@puerco
Copy link
Member

puerco commented Dec 2, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit da50388 into kubernetes:release-1.22 Dec 2, 2021
@liggitt liggitt mentioned this pull request Jan 24, 2022
Closed
@TeddyAndrieux TeddyAndrieux mentioned this pull request Jan 28, 2022
Closed
@gjkim42 gjkim42 deleted the automated-cherry-pick-of-#104743-upstream-release-1.22 branch February 5, 2022 05:42
@tossmilestone tossmilestone mentioned this pull request Apr 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp mrunalp approved these changes

@odinuge odinuge Awaiting requested review from odinuge

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@smarterclayton smarterclayton

@puerco puerco

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gjkim42 @k8s-ci-robot @puerco @mrunalp @ehashman @smarterclayton @hasheddan