Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubeadm]: Bump CoreDNS version to 1.8.0 #96429

Merged
merged 2 commits into from Dec 29, 2020
Merged

[kubeadm]: Bump CoreDNS version to 1.8.0 #96429

merged 2 commits into from Dec 29, 2020

Conversation

rajansandeep
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bumps the CoreDNS version to v1.8.0 in kubeadm
Also updates the corefile-migration library to v1.0.11 which supports CoreDNS v1.8.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kubeadm now includes CoreDNS v1.8.0.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from lavalamp, neolit123 and a team November 10, 2020 20:56
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2020
@rajansandeep
Copy link
Contributor Author

/cc @chrisohaver

neolit123
neolit123 reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for kubeadm

@rajansandeep any notable / breaking changes in 1.8.0 that we need to add in the k/k release note?

@neolit123
Copy link
Member

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 10, 2020
@neolit123
Copy link
Member

ERROR: error building node image: command "docker save -o /tmp/kind-build151110249/bits/images/5.tar k8s.gcr.io/coredns:1.8.0" failed with error: exit status 1

we are missing the 1.8.0 image at GCR.

@rajansandeep
Copy link
Contributor Author

ERROR: error building node image: command "docker save -o /tmp/kind-build151110249/bits/images/5.tar k8s.gcr.io/coredns:1.8.0" failed with error: exit status 1

we are missing the 1.8.0 image at GCR.

The PR to promote the CoreDNS image was merged today. kubernetes/k8s.io#1405
Not sure how long it'll take to reflect

@neolit123
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 10, 2020
@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2020
@rajansandeep
Copy link
Contributor Author

/retest
/assign @liggitt
(for vendor)

@liggitt
Copy link
Member

liggitt commented Nov 17, 2020

/approve
for deps

/hold is this fixing a release-blocking bug or has a feature exception been requested? if not, this should move to the 1.21 milestone. At first glance, this seems late in the cycle to be bumping an addon version

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@jeremyrickard
Copy link
Contributor

Hey there, 1.20 release lead here 👋

As @LiGgit mentioned, we're pretty late in the cycle so I'm going to bump this to 1.21. Please reach out if this is release blocking and we can discuss re-milestoning back.

/milestone v1.21

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.20, v1.21 Nov 18, 2020
neolit123
neolit123 reviewed Dec 15, 2020
View reviewed changes
cmd/kubeadm/app/constants/constants.go
@@ -323,7 +323,7 @@ const (
CoreDNSDeploymentName = "coredns"

// CoreDNSImageName specifies the name of the image for CoreDNS add-on
CoreDNSImageName = "coredns"
CoreDNSImageName = "coredns/coredns"
Copy link
Member

@neolit123 neolit123 Dec 15, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just noticed this new sub path (and v prefix)

could you please add the following second sentence in the release note:

The v1.8.0 image is now located in a "coredns" sub-path and the tag is prefixed with "v": k8s.gcr.io/coredns/coredns:v1.8.0

in case someone assumes the image is at k8s.gcr.io/coredns:1.8.0

you can /hold cancel after that and the PR should merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we make custom Kind node image, it does have an assumption on k8s.gcr.io/coredns:1.8.0,
now it breaks the basic workflow of making custom kind node image.

the question is why we are making a change on path? @rajansandeep cc @neolit123

neolit123
neolit123 reviewed Dec 15, 2020
View reviewed changes
cmd/kubeadm/app/constants/constants.go
@@ -344,7 +344,7 @@ const (
KubeDNSVersion = "1.14.13"

// CoreDNSVersion is the version of CoreDNS to be deployed if it is used
CoreDNSVersion = "1.7.0"
CoreDNSVersion = "v1.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting that if one day we want to not use a certain version of coredns with a version of k8s, we may have to introduce the same mapping / table as the one for etcd on line 448.

neolit123
neolit123 reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@aojea
Copy link
Member

aojea commented Dec 18, 2020

/approve
for deps

/hold is this fixing a release-blocking bug or has a feature exception been requested? if not, this should move to the 1.21 milestone. At first glance, this seems late in the cycle to be bumping an addon version

we are in 1.21 , does this hold still apply or should we merge?

@neolit123
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 80be1d6 into kubernetes:master Dec 29, 2020
@neolit123 neolit123 mentioned this pull request Dec 30, 2020
Closed
@github-actions github-actions bot mentioned this pull request Jan 5, 2021
Open
This was referenced Mar 4, 2021
Closed
Merged
@TimeBye TimeBye mentioned this pull request Apr 12, 2021
Closed
@neolit123
Copy link
Member

neolit123 commented May 21, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figo figo figo left review comments

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@chrisohaver chrisohaver Awaiting requested review from chrisohaver

Assignees

@neolit123 neolit123

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rajansandeep @neolit123 @BenTheElder @liggitt @k8s-ci-robot @jeremyrickard @aojea @fejta-bot @figo